Few changes #1
Closed
Few changes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Include params in config/enc.pp as I include this on puppetmasters that do not run foreman. * Include the mysql gem by default (this will need to be improved by someone to have a boundary for RHEL as it won't work on Debian) * Fix a typo in the external_node.rb.erb template. * Change latest to present.
| require => Class['foreman::install::repos'], | ||
| notify => Class['foreman::service'], | ||
| } | ||
|
|
||
| package{[ "mysql-devel", "gcc", "ruby-devel" ]: | ||
| ensure => present, | ||
| } |
There was a problem hiding this comment.
i think this stuff should not be required any more (using the new rpms?)
|
@apenney - Ohad's right, those package resources shouldn't be required any more. Everything else is great, can you update the pull request? |
| @@ -4,7 +4,7 @@ SETTINGS = { | |||
| :url => "<%= scope.lookupvar('foreman::params::foreman_url')%>", | |||
| :puppetdir => "<%= scope.lookupvar('foreman::params::puppet_home')%>", | |||
| :facts => "<%= scope.lookupvar('foreman::params::facts')%>", | |||
| :storeconfigs => "<%= scope.lookupvar('foreman::params::storeconfig')%>", | |||
There was a problem hiding this comment.
actually, this looks wrong, it should be a boolean and not a string, e.g.
:facts => true, vs :facts => "true"
|
I've clean it up and merged it. |
mcanevet
referenced
this pull request
in mcanevet/puppet-foreman
Mar 13, 2013
Resync with theforeman's github
jistr
referenced
this pull request
in jistr/puppet-foreman
May 27, 2013
Use SCL paths for config files
jturel
pushed a commit
to jturel/puppet-foreman
that referenced
this pull request
May 1, 2018
Changes for Puppet 2.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(The typo is the most useful bit of this, I included the mysql gem stuff despite the fact I haven't done the work to ensure it's only relevant for rhel, and uses a params.pp to decide if to include and all that just to get it checked in for now. If I was smarter I'd know how to break this pull request apart into just the changes I want but I made them as one big commit).
that do not run foreman.
by someone to have a boundary for RHEL as it won't work on Debian)