Add check for file to migrate and seed database #776
Conversation
There was a problem hiding this comment.
I was thinking of two helpers that we'll ship in /usr/libexec. The first one that returns whether a migration is needed via an exit code so you can also script foreman-should-migrate || foreman-rake db:migrate. The other would clear the migration marker. Something like foreman-request-migration. For all of these we'll also need something for seeding. Then the %post packaging macro will essentially run foreman-request-migration instead of actually migrating. These scripts can be simple shell scripts.
I would prefer keeping these wrappers in foreman.git. By keeping them in foreman.git, we can later easily decide to change the implementation. If other configuration management tools (like Ansible) want to use the same mechanism, they can. We can even decide to make sure db:migrate and db:seed actually creates the files.
I also think the markers should live in /var/lib/foreman.
| @@ -14,6 +15,7 @@ | |||
| logoutput => 'on_failure', | |||
| refreshonly => true, | |||
| timeout => $timeout, | |||
| unless => $unless, | |||
There was a problem hiding this comment.
You can also expose the creates parameter which is closer to what you want now
| ~> foreman_config_entry { 'db_pending_seed': | ||
| value => false, | ||
| dry => true, | ||
| } ~> | ||
| file { '/etc/foreman/database_seeded': |
There was a problem hiding this comment.
You should do this after seeding.
|
Given #778, should we close this out? |
This is working to replace RPMs running migration steps by driving the database migration and seed via the existence of files. There are two approaches that could be taken:
I went back and forth and landed on a more installer centric view via #1. I perceived benefits were:
I'm open to option #2 as an alternative this just puts a burden on external creation of these files for the initial installer run (which can reasonably be expected but feels bad).