Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the separate rails repository #826

Merged
merged 1 commit into from
Apr 18, 2020
Merged

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Apr 17, 2020

Foreman 2.0 dropped this and needs to be removed.

Copy link
Contributor

@wbclark wbclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test which checks that this repo is present in the catalogue should now test for ensure => absent instead

Foreman 2.0 dropped this and needs to be removed.
@ekohl
Copy link
Member Author

ekohl commented Apr 18, 2020

Updated the tests. Ubuntu acceptance tests failing on journald, but I suspect that dynflow took just too long to start up. Essentially a race condition and not related to the files I changed.

@mmoll mmoll merged commit 4324f24 into theforeman:master Apr 18, 2020
@mmoll
Copy link
Contributor

mmoll commented Apr 18, 2020

merged, bedankt @ekohl!

@ekohl ekohl deleted the drop-rails-repo branch May 1, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants