Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #29212 - support el8 #828

Merged
merged 1 commit into from
May 8, 2020
Merged

Fixes #29212 - support el8 #828

merged 1 commit into from
May 8, 2020

Conversation

wbclark
Copy link
Contributor

@wbclark wbclark commented Apr 17, 2020

This is a WIP which incorporates the PRs #826 & #827 .

@wbclark
Copy link
Contributor Author

wbclark commented Apr 17, 2020

When I test locally with EL7 it's failing due to the known issue: https://projects.theforeman.org/issues/29429

With EL8, an error occurs when running puppet apply: Error: Could not find a suitable provider for foreman_config_entry

ekohl
ekohl requested changes Apr 23, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#699 would make this much easier. Also needs a rebase now.

@mmoll
Copy link
Contributor

mmoll commented May 4, 2020

@wbclark please rebase :)

@ekohl
Copy link
Member

ekohl commented May 4, 2020

In this module, you need to ensure the en locales are present due to how we configure postgresql. I wonder if we should ensure this in foreman::install.

@wbclark
Copy link
Contributor Author

wbclark commented May 5, 2020

In this module, you need to ensure the en locales are present due to how we configure postgresql. I wonder if we should ensure this in foreman::install.

I've opened #837 to do this for the RedHat family of operating systems when the database is managed.

@wbclark wbclark changed the title El8 Fixes #29212 - support el8 May 7, 2020
@wbclark wbclark force-pushed the el8 branch 9 times, most recently from 362afb0 to 4142db5 Compare May 8, 2020 03:04
@wbclark
Copy link
Contributor Author

wbclark commented May 8, 2020

test failure is due to: https://projects.theforeman.org/issues/29429

ehelms
ehelms approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@ehelms ehelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since it only failing on the known https://projects.theforeman.org/issues/29429 issue

@mmoll mmoll merged commit 24e384c into theforeman:master May 8, 2020
@mmoll
Copy link
Contributor

mmoll commented May 8, 2020

merged, thanks @wbclark!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl requested changes

@ehelms ehelms ehelms approved these changes

Assignees
No one assigned
Labels
Enhancement Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wbclark @mmoll @ekohl @ehelms @theforeman-bot