Add Entity:getRenderBounds() #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegrb93
requested changes
Aug 21, 2024
lua/starfall/libs_sh/entities.lua
Outdated
Comment on lines
255
to
258
| local sf_userrenderbounds = ent.sf_userrenderbounds | ||
| if sf_userrenderbounds then | ||
| return vwrap(sf_userrenderbounds[1]), vwrap(sf_userrenderbounds[2]) | ||
| end |
There was a problem hiding this comment.
GetRenderBounds should return the same thing as this right? Probably don't need this.
thegrb93
approved these changes
Aug 21, 2024
github-actions bot
added a commit
that referenced
this pull request
Aug 23, 2024
* Add Entity:getRenderBounds() * Edit Entity:getRenderBounds() ce6506e
thegrb93
pushed a commit
that referenced
this pull request
Aug 23, 2024
* Add Entity:getRenderBounds() * Edit Entity:getRenderBounds()
thegrb93
added a commit
that referenced
this pull request
Aug 28, 2024
* Start refactor * progress * move * Fixes serverside errors (#1829) * Progress * More progress * Big refactor * Remove code param * Progress * Forgot this * Fixes * more progress * Fix trace not working for entity subtypes (#1832) * Additional isvalid checks (#1831) * Make starfall error hook use 'world' for server errors (#1833) * Make starfall error hook use 'world' for server errors * Use world instead of false for server errors * Add Entity:getRenderBounds() (#1834) * Add Entity:getRenderBounds() * Edit Entity:getRenderBounds() * Fixes * Add file and line number to preprocessor errors * small fix * fix * add E2 to :hasInstance() (#1837) * add E2 to :hasInstance() * return false if neither sf or e2 * For prop.createSent(): check if frozen is a boolean (#1838) * For prop.createSent(): check if frozen is a boolean I forgot to specify `frozen` in one of my SF projects and my `data` ended up in its place, yet I received no error and it wasn't until I spent 1 second of my life to double-check docs when I fixed my problem. I highly doubt anyone is going to get any problems with me adding one extra check that 99% of good starfalls won't crash from. * Update lua/starfall/libs_sv/prop.lua Co-authored-by: thegrb93 <grbrown93@sbcglobal.net> * Update prop.lua * Update prop.lua * Copy frozen prop param fix to other spawn functions (#1839) * Copy frozen prop param fix to other spawn functions * Missed one * Fix * Final fixes --------- Co-authored-by: ъ знака <111152233+friztailo@users.noreply.github.com> Co-authored-by: ax255 <66443256+ax255@users.noreply.github.com> Co-authored-by: SuperTemich2005 <39464061+SuperTemich2005@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need it.