-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For prop.createSent(): check if frozen is a boolean #1838
Conversation
I forgot to specify `frozen` in one of my SF projects and my `data` ended up in its place, yet I received no error and it wasn't until I spent 1 second of my life to double-check docs when I fixed my problem. I highly doubt anyone is going to get any problems with me adding one extra check that 99% of good starfalls won't crash from.
Co-authored-by: thegrb93 <grbrown93@sbcglobal.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've taken what @thegrb93 suggested and decided to add one extra else-check to set frozen
to false
(because after removing old line 416, we didn't have anything to assume false for frozen
and make sure that that one example starfall doesn't crash anymore). i'm not a glua expert but it doesn't look like it's going to instantly crash, and that's good, i guess?
* For prop.createSent(): check if frozen is a boolean I forgot to specify `frozen` in one of my SF projects and my `data` ended up in its place, yet I received no error and it wasn't until I spent 1 second of my life to double-check docs when I fixed my problem. I highly doubt anyone is going to get any problems with me adding one extra check that 99% of good starfalls won't crash from. * Update lua/starfall/libs_sv/prop.lua Co-authored-by: thegrb93 <grbrown93@sbcglobal.net> * Update prop.lua * Update prop.lua 0949b29
* For prop.createSent(): check if frozen is a boolean I forgot to specify `frozen` in one of my SF projects and my `data` ended up in its place, yet I received no error and it wasn't until I spent 1 second of my life to double-check docs when I fixed my problem. I highly doubt anyone is going to get any problems with me adding one extra check that 99% of good starfalls won't crash from. * Update lua/starfall/libs_sv/prop.lua Co-authored-by: thegrb93 <grbrown93@sbcglobal.net> * Update prop.lua * Update prop.lua
* Start refactor * progress * move * Fixes serverside errors (#1829) * Progress * More progress * Big refactor * Remove code param * Progress * Forgot this * Fixes * more progress * Fix trace not working for entity subtypes (#1832) * Additional isvalid checks (#1831) * Make starfall error hook use 'world' for server errors (#1833) * Make starfall error hook use 'world' for server errors * Use world instead of false for server errors * Add Entity:getRenderBounds() (#1834) * Add Entity:getRenderBounds() * Edit Entity:getRenderBounds() * Fixes * Add file and line number to preprocessor errors * small fix * fix * add E2 to :hasInstance() (#1837) * add E2 to :hasInstance() * return false if neither sf or e2 * For prop.createSent(): check if frozen is a boolean (#1838) * For prop.createSent(): check if frozen is a boolean I forgot to specify `frozen` in one of my SF projects and my `data` ended up in its place, yet I received no error and it wasn't until I spent 1 second of my life to double-check docs when I fixed my problem. I highly doubt anyone is going to get any problems with me adding one extra check that 99% of good starfalls won't crash from. * Update lua/starfall/libs_sv/prop.lua Co-authored-by: thegrb93 <grbrown93@sbcglobal.net> * Update prop.lua * Update prop.lua * Copy frozen prop param fix to other spawn functions (#1839) * Copy frozen prop param fix to other spawn functions * Missed one * Fix * Final fixes --------- Co-authored-by: ъ знака <111152233+friztailo@users.noreply.github.com> Co-authored-by: ax255 <66443256+ax255@users.noreply.github.com> Co-authored-by: SuperTemich2005 <39464061+SuperTemich2005@users.noreply.github.com>
If passed, prop.createSent() will explicitly check if frozen is a boolean.