Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move_to_x: Fix name of non-implemented argument "copy" to "copy_x", implement & test #832

Merged
merged 2 commits into from
Dec 2, 2024
Merged

move_to_x: Fix name of non-implemented argument "copy" to "copy_x", implement & test #832

merged 2 commits into from
Dec 2, 2024

Conversation

eroell
Copy link
Collaborator

@eroell eroell commented Dec 1, 2024

PR Checklist

  • This comment contains a description of changes (with reason)
  • Referenced issue is linked
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

move_to_x currently has a non-implemented argument copy in its documentation.
move_to_obs has an argument copy_obs; in this style, now implemented an argument copy_x in move_to_x.

@github-actions github-actions bot added the bug Something isn't working label Dec 1, 2024
@eroell eroell requested a review from Zethson December 1, 2024 18:27
@Zethson Zethson merged commit ee84d9e into main Dec 2, 2024
14 of 15 checks passed
@Zethson Zethson deleted the fix/move-to-x branch December 2, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zethson Zethson Zethson approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eroell @Zethson