Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set defaults for lr sinkhorn #739

Merged
merged 4 commits into from
Sep 9, 2024
Merged

set defaults for lr sinkhorn #739

merged 4 commits into from
Sep 9, 2024

Conversation

MUCDK
Copy link
Collaborator

@MUCDK MUCDK commented Aug 21, 2024

No description provided.

@MUCDK
Copy link
Collaborator Author

MUCDK commented Aug 21, 2024

resolves #705

@MUCDK MUCDK requested a review from selmanozleyen August 21, 2024 13:56
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.04%. Comparing base (f940c18) to head (2bbcd55).
Report is 175 commits behind head on main.

Files with missing lines Patch % Lines
src/moscot/backends/ott/solver.py 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #739      +/-   ##
==========================================
- Coverage   78.14%   77.04%   -1.10%     
==========================================
  Files          36       36              
  Lines        3834     4370     +536     
  Branches      705      807     +102     
==========================================
+ Hits         2996     3367     +371     
- Misses        526      651     +125     
- Partials      312      352      +40     
Files with missing lines Coverage Δ
src/moscot/backends/ott/solver.py 90.25% <75.00%> (-1.32%) ⬇️

... and 3 files with indirect coverage changes

Copy link
Collaborator

@selmanozleyen selmanozleyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd think we should document the default gamma somewhere but it shouldn't matter as we are going to remove kwargs from the solve method in the future. So gamma can be explicitly documented there

@MUCDK MUCDK merged commit 2025d82 into main Sep 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants