Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for duplicate columns #311

Merged
merged 5 commits into from
Dec 9, 2022
Merged

Add test for duplicate columns #311

merged 5 commits into from
Dec 9, 2022

Conversation

mumichae
Copy link
Collaborator

@mumichae mumichae commented May 13, 2022

Close #311

@mumichae mumichae requested a review from MxMstrmn May 13, 2022 18:31
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #311 (3cde909) into main (9628f5b) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
+ Coverage   60.16%   60.40%   +0.24%     
==========================================
  Files          40       40              
  Lines        2149     2157       +8     
==========================================
+ Hits         1293     1303      +10     
+ Misses        856      854       -2     
Flag Coverage Δ
unittest 60.40% <100.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/integration/test_scanorama.py 100.00% <ø> (ø)
tests/preprocessing/test_preprocessing.py 100.00% <100.00%> (ø)
scib/utils.py 72.72% <0.00%> (+4.54%) ⬆️

@mumichae mumichae merged commit 6c8b2a0 into main Dec 9, 2022
@mumichae mumichae deleted the test/dup_cols branch December 9, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant