Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPU_id param for DESC #372

Merged
merged 4 commits into from
Feb 2, 2023
Merged

Add GPU_id param for DESC #372

merged 4 commits into from
Feb 2, 2023

Conversation

johnarevalo
Copy link
Contributor

Without the GPU_id param, DESC method does not use the GPU.

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #372 (07a63d2) into main (2ae3d08) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #372   +/-   ##
=======================================
  Coverage   53.34%   53.34%           
=======================================
  Files          22       22           
  Lines        1854     1854           
=======================================
  Hits          989      989           
  Misses        865      865           
Flag Coverage Δ
unittests 53.34% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scib/integration.py 36.20% <100.00%> (ø)

Copy link
Collaborator

@LuckyMD LuckyMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the PR! We didn't actually test any of the methods on GPU, but this doesn't break the CPU workflow, so all good.

@mumichae mumichae merged commit 57b3389 into theislab:main Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants