Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use precomputed clustering #406

Merged
merged 14 commits into from
Apr 22, 2024
Merged

Use precomputed clustering #406

merged 14 commits into from
Apr 22, 2024

Conversation

mumichae
Copy link
Collaborator

@mumichae mumichae commented Apr 17, 2024

Improve performance of clustering function to reduce redundant kNN and clustering operations

  • cluster_optimal_resolution will not rerun sc.pp.neighbors or clustering by default if cluster key exists for the specified resolution (by name matching)`
  • update get_resolutions function to scale equally between 0 and n

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 58.16%. Comparing base (127e41e) to head (2b3230d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
+ Coverage   57.85%   58.16%   +0.31%     
==========================================
  Files          22       22              
  Lines        1675     1683       +8     
==========================================
+ Hits          969      979      +10     
+ Misses        706      704       -2     
Flag Coverage Δ
unittests 58.16% <96.96%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scib/metrics/isolated_labels.py 93.65% <100.00%> (+0.66%) ⬆️
scib/metrics/clustering.py 88.34% <96.15%> (+2.21%) ⬆️

@mumichae mumichae merged commit 9c5a936 into main Apr 22, 2024
11 checks passed
@mumichae mumichae deleted the use_precomputed_clustering branch April 22, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant