Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is memory cleared in sequential loading to backed? #61

Closed
davidsebfischer opened this issue Jan 7, 2021 · 1 comment · Fixed by #38
Closed

Is memory cleared in sequential loading to backed? #61

davidsebfischer opened this issue Jan 7, 2021 · 1 comment · Fixed by #38
Assignees
@le-ander
Milestone
data base usage

Comments

@davidsebfischer
Copy link
Contributor

I did not find a statement that deletes self.adata in backed loading in the base classes. I just added a clearfunction in DatasetBasethat would be required to do this clearing (#38).
davidsebfischer added a commit that referenced this issue Jan 7, 2021
@davidsebfischer
simplified data loading with custom actions on data sets
ea8bc06 
- allowed temporary loading with custom function execution
- applied this to meta data loading
- introduced .adata clearing function (#61)
@le-ander
Copy link
Member

hm, good point. I guess we can just add a call to clear after we have appended the data to the backed object. I'll push this.

le-ander added a commit that referenced this issue Jan 11, 2021
@le-ander
clear datasets from memory after copying during backed writing. closes …
fd7cbab 
…#61
@le-ander le-ander linked a pull request Jan 11, 2021 that will close this issue
Adjust data loaders to directory-wise set-up #38
Merged
@davidsebfischer davidsebfischer added this to the data base usage milestone Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@le-ander le-ander

Labels
None yet
Projects
None yet
Milestone
data base usage
Development

Successfully merging a pull request may close this issue.

Adjust data loaders to directory-wise set-up theislab/sfaira
2 participants
@davidsebfischer @le-ander