Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add composite actions #1256

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Add composite actions #1256

merged 1 commit into from
Jan 18, 2023

Conversation

taku333
Copy link
Contributor

@taku333 taku333 commented Dec 27, 2022 •
edited by adejanovski
Loading

Thanks for your time.
I have always used Reaper.
I have modified Actinos to contribute to open source.
I modified it to be a reusable source if you use "Creating a composite action".
Please check it out.

https://docs.github.com/en/actions/creating-actions/creating-a-composite-action

Fixes #1257

@taku333 taku333 mentioned this pull request Dec 27, 2022
Closed
@taku333
Copy link
Contributor Author

taku333 commented Dec 27, 2022

#1257

adejanovski
adejanovski requested changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@adejanovski adejanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this PR! I'd love to see this working, but there seems to be a typo currently.

.github/workflows/ci.yaml Outdated
python-version: '3.x'
architecture: 'x64'
- name: Setup
uses: ./github/actions/setup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: ./github/actions/setup
uses: .github/actions/setup

CI is failing because it's complaining that the action cannot be found.
Most probably because it's under .github instead of ./github.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply.
Sorry for the typo.
I will upload the corrected version here soon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix completed.
https://github.com/thelastpickle/cassandra-reaper/compare/1f394965fdc0facc260c0a75a5827f7840c3ce75..558cb6f148ff3807f5cf513037597a1ffd0a3961

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adejanovski
Please check again.

@taku333 taku333 force-pushed the feature/add-composite-actions branch from 1f39496 to 558cb6f Compare January 8, 2023 06:30
@taku333
Copy link
Contributor Author

taku333 commented Jan 14, 2023

@adejanovski
Error in CI / Build Reaper (pull_request)

Error:  Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (default) on project cassandra-reaper-pom: Too many files with unapproved license: 1 See RAT report in: /home/runner/work/cassandra-reaper/cassandra-reaper/target/rat.txt -> [Help 1]
[66](https://github.com/thelastpickle/cassandra-reaper/actions/runs/3865835236/jobs/6598554847#step:4:67)
Error:  
[67](https://github.com/thelastpickle/cassandra-reaper/actions/runs/3865835236/jobs/6598554847#step:4:68)
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
[68](https://github.com/thelastpickle/cassandra-reaper/actions/runs/3865835236/jobs/6598554847#step:4:69)
Error:  Re-run Maven using the -X switch to enable full debug logging.
[69](https://github.com/thelastpickle/cassandra-reaper/actions/runs/3865835236/jobs/6598554847#step:4:70)
Error:  
[70](https://github.com/thelastpickle/cassandra-reaper/actions/runs/3865835236/jobs/6598554847#step:4:71)
Error:  For more information about the errors and possible solutions, please read the following articles:
[71](https://github.com/thelastpickle/cassandra-reaper/actions/runs/3865835236/jobs/6598554847#step:4:72)
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[72](https://github.com/thelastpickle/cassandra-reaper/actions/runs/3865835236/jobs/6598554847#step:4:73)
Error: Process completed with exit code 1.

Is it because you added files without license settings, such as .github/actions/setup/action.yml?

@adejanovski
Copy link
Contributor

@adejanovski Error in CI / Build Reaper (pull_request)

Error:  Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (default) on project cassandra-reaper-pom: Too many files with unapproved license: 1 See RAT report in: /home/runner/work/cassandra-reaper/cassandra-reaper/target/rat.txt -> [Help 1]
[66](https://github.com/thelastpickle/cassandra-reaper/actions/runs/3865835236/jobs/6598554847#step:4:67)
Error:  
[67](https://github.com/thelastpickle/cassandra-reaper/actions/runs/3865835236/jobs/6598554847#step:4:68)
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
[68](https://github.com/thelastpickle/cassandra-reaper/actions/runs/3865835236/jobs/6598554847#step:4:69)
Error:  Re-run Maven using the -X switch to enable full debug logging.
[69](https://github.com/thelastpickle/cassandra-reaper/actions/runs/3865835236/jobs/6598554847#step:4:70)
Error:  
[70](https://github.com/thelastpickle/cassandra-reaper/actions/runs/3865835236/jobs/6598554847#step:4:71)
Error:  For more information about the errors and possible solutions, please read the following articles:
[71](https://github.com/thelastpickle/cassandra-reaper/actions/runs/3865835236/jobs/6598554847#step:4:72)
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[72](https://github.com/thelastpickle/cassandra-reaper/actions/runs/3865835236/jobs/6598554847#step:4:73)
Error: Process completed with exit code 1.

Is it because you added files without license settings, such as .github/actions/setup/action.yml?

Yes, we have a check for files to have a valid license header:

# Copyright 2023-2023 DataStax Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

Would you mind signing our CLA for that header to be valid? Thanks!

@taku333 taku333 force-pushed the feature/add-composite-actions branch from 558cb6f to 5a2a6f3 Compare January 17, 2023 06:43
@taku333
Copy link
Contributor Author

taku333 commented Jan 17, 2023

@adejanovski
Signed into CLA and added license header.

adejanovski
adejanovski approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@adejanovski adejanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now ✅ Thanks!

@adejanovski adejanovski merged commit 675bf05 into thelastpickle:master Jan 18, 2023
@taku333 taku333 deleted the feature/add-composite-actions branch January 18, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adejanovski adejanovski adejanovski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Composite action is not used.
2 participants
@taku333 @adejanovski