docs(list.stories.tsx): add list with icon storybook #1311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Important Auto Review SkippedMore than 25% of the files skipped due to max files limit. Skipping review to prevent low quality review. 172 files out of 296 files are above the max files limit of 100. WalkthroughThis update introduces a new story titled Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
@SutuSebastian Hi Seba, pls check this one... |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1311 +/- ##
==========================================
- Coverage 99.54% 95.53% -4.01%
==========================================
Files 163 217 +54
Lines 6621 9685 +3064
Branches 401 560 +159
==========================================
+ Hits 6591 9253 +2662
- Misses 30 432 +402 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- src/components/List/List.stories.tsx (2 hunks)
Additional comments: 2
src/components/List/List.stories.tsx (2)
- 4-4: The import statement for
HiCheckCircleis correctly implemented and follows best practices for importing icons fromreact-icons/hi.- 101-111: The
WithIconListstory is correctly implemented, demonstrating the use of icons in list items effectively. The story follows established patterns and conventions in the file.
* monorepo init: - bun [runtime, package manager, task runner, test runner] - biome [format, lint] - removed `cypress` (to be replaced with `playwright`) - removed codecov - split into multiple packages and apps [web(docs), ui(library), storybook, cli] UNSTABLE * (web): remove unused packages * remove eslint disable rules comments * fix some linting errors * (web): link library to monorepo `ui` package * fix(web): build fix(ui): exports fix(root): sort `package.json` * package upgrade * fix(storybook): - replace `@vitejs/plugin-react-sw` -> `@vitejs/plugin-react` - fix build - add `.gitignore` - update stories path * move git related files in `.git` * cleanup: - remove `biome` and drop `bun:test` until stable - add `prettier` - imporve `.vscode` files and add extentions suggestions * - restore prettier config + add tailwind formatting support - remove more biome leftover - add package json sorter * upgrade all packages * refactor: - prettier config: add import sorting - format files * packages: up * packages: up storybook * fix: prettier plugin order * chore(ui): add `vitest`; add missing `Accordion.spec` import * chore(root): add turbo test commands and format `package.json` * fix: intellisense and tailwind support; add `eslint` * fix(lib): lint errors * feat(ui): add `createTheme` tailwindcss intellisense function * refactor(ui): use new tailwindcss shorthands * fix(storybook/banner): remove invalid tailwind classes * chore: add `.editorconfig` * refactor(ui): wrap all components `theme` with `createTheme` to gain class sorting, linting and apply fixes * fix: prettier config for root and for apps and packages; format code * refactor: move common eslint packages to root `package.json`; - add `eslint` to `web` - optimise onboarding flow - fix tailwind lint errors here and there * chore: up packages * refactor: (web) lint rules + fix examples * refactor: CI/CD improvements: - refactor github actions - setup github actions using `bun` - remove storybook github action (redo later) * fix: CI/CD setup action, add missing required property * fix(web): typecheck * fix(lib): type module for failing tests * fix(lib): `package.json` meta and npm tags; update peerDeps * fix(lib: tsconfig exclude * fix(lib): rename eslint config to cjs since `"type": "module"` * fix(web): eslint nextjs rule; supposably fixed flicker on reload * fix(lib): merge-deep test * chore(lib): eslint config updates * fix(lib): bypass `datepicker` test (unfinished) * refactor(lib): remove `toggleSwitchTheme` empty space * chore: up packages * fix(lib): failing tests due to concurrency * fix(lib): test coverage + format files * refactor(global): switch from `singleQuote` to double * refactor(lib): more tailwind shorthands * chore: up packages * chore: up packages * packages(cli): add first version general: update packages * packages(cli): fix typecheck * packages(cli): refactor - add [dir] argument - add [options] argument - `--template <name>` - `-h, --help` * packages(cli): add `-v, --version` in [options] * packages(cli): add `README.md` * fix: package.json repository.url * packages(cli): add `--git` option * packages(cli): up package version * packages(cli): update `README.md` * packages(cli): bump package version patch * config: sort and tidy up .vscode settings.json * fix(docs): navbar package version * fix(docs): mdx heading color * feat(docs): code demo: - add screen size controls (desktop/tablet/mobile) - add RTL control * feat(docs): code demo: - add tooltip to copy-to-clipboard - fix icon sizes * feat(docs): create `CLI` page * feat(docs): integratoin guides - add `CLI` and `Templates` sections * fix(web): homepage - components section hover styles; sidebar - more spacing (synced with @robert) * packages(cli): update `README.md` apps(web): update CLI page * packages(cli): bump package version patch * apps(web): update `README.md`, `CONTRIBUTING` files; change integration guides order based on popularity/category; remove redundant `typescript` page packages(cli): change integration guides order based on popularity/category; bump version (patch) * apps(web): fix, rewrite and simplify `introduction` and `quickstart` pages * apps(web): fix narrow context * apps(web): small style fixes * chore: up packages + format * apps(web): add `Editor Setup` page * apps(web): remix guide: add dark mode section * apps(web): refactor `Dark mode` page * fix: color flicker on reload + move background and text color to root layout * packages(ui): fix alert them blue color * apps(web): code demo: isolate dark/light mode * apps(web): inline code: add background * feat: add `changeset` * chore: move `CHANGELOG` to packages/ui * chore: add self to `FUNDING` * chore: add `@changesets/changelog-github` * chore: up packages * core improvements: - add `rimraf` for windows support - add `clean-package` for cleaner `package.json` file (used for `flowbite-react` and `create-flowbite-react` packages) * packages(cli): change intro color from `blue` to `cyan` + bump version (patch) * packages(cli): update package.json - add [homepage, bugs] links * chore: move root `README.md` to `packages/ui` + create symlink from it to root * core(ci): test build sync times * core(ci): test build async times * chore: format * fix: turbo.json configs and isolate using turbo workspaces * chore: CLI commands to use @latest for `pnpm` and `bun` * chore: version `packages/cli` * chore: remove random code example * chore: spacing * chore: up `packageManager` version * fix: storybook next dependency examples * chore: up packages, see if it fixes storybook build failure * fix: storybook types * fix: storybook warning * packages(ui): fix version * chore: up `packageManager` version * chore: up packages, see if it fixes storybook build failure * chore: rebuild lock file, check if storybook fails * chore: CI cache clear before install * chore: undo CI cache clear before install * chore: downgrade `packageManager` from `bun@1.0.33` to stable `bun@1.0.31` due to storybook failing; update some packages * chore: bump storybook packages * fix(ui): polymorphic component return type -> type casting * chore: simplify types * chore: bump package from merge conflict --------- Co-authored-by: SutuSebastian <sebastian.sutu@stainless-code.com>
…ghar/flowbite-react into feat/list-with-icon-stroybook
|
I think the best here would be to re-create the PR, since the |
|
Closed by #1316. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add list with icon storybook
There are no breaking API changes.
Summary by CodeRabbit