-
-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): add With Icon storybook #1316
feat(ui): add With Icon storybook #1316
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis update introduces a new visual story to the List component, showcasing a list with icons using Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
bf640db
to
6a47ef3
Compare
@SutuSebastian Hey dear Sebastian, pls take a look at this change... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- packages/ui/src/components/List/List.stories.tsx (2 hunks)
Additional comments: 2
packages/ui/src/components/List/List.stories.tsx (2)
- 4-4: The import of
HiCheckCircle
fromreact-icons/hi
is correctly done and is essential for the newWithIconList
story.- 101-111: The
WithIconList
story is correctly added and follows the established pattern for story definitions. It effectively demonstrates the integration of icons within the list component.Please ensure that the
List.Item
component properly supports theicon
prop as used here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- packages/ui/src/components/List/List.stories.tsx (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/ui/src/components/List/List.stories.tsx
abdb758
to
daf7944
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- packages/ui/src/components/List/List.stories.tsx (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/ui/src/components/List/List.stories.tsx
* feat(ui): add With Icon storybook * format(ui): run formatter
Add "With Icon" storybook
There are no breaking API changes.
Summary by CodeRabbit
WithIconList
to the List component in UI documentation, demonstrating lists with icons usingHiCheckCircle
.