Read headers in batch on getRows() #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read headers in batch on getRows()
|
Sorry for the delay. This is great! Will get this merged soon :) |
…dleRejection error and crash the BB server
Add await when processing header to avoid unhandleRejection theoephraim#698
theoephraim
pushed a commit
that referenced
this pull request
Aug 31, 2024
* Get header on batch when reading without header loaded * Add tests * Added await to processHeader function as failure would cause an unhandleRejection error and crash the BB server * Adding yarn.lock, publishing new named version. --------- Co-authored-by: Dean <deanhannigan@gmail.com> Co-authored-by: Michael Drury <me@michaeldrury.co.uk>
junedomingo
added a commit
to junedomingo/node-google-spreadsheet
that referenced
this pull request
Sep 23, 2024
* main: wiring up github action to dmno chore: release v4.1.4 add dmno and remove/encrypt test-related secrets, swap jest for vitest fix(updateProperties): getFieldMask ignore gridProperties (theoephraim#674) chore: release v4.1.3 fix bugs introduced by PRs update axios, fix new google-auth-library issue, fixes theoephraim#701 theoephraim#700 Read headers in batch on getRows() (theoephraim#693) Update authentication.md allow CI manual reruns Update FUNDING.yml use correct type in docs # Conflicts: # .gitignore # pnpm-lock.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current flow, when running getRows, checks if the headers are loaded. If they are not, we first load the headers and then we run the get. These 2 calls are slow, and they can be speed up using the batchGet endpoint provided by google