refactor: Drop redundant columns from teams table

[RODO94]

What does this PR do?

I have dropped all columns in the teams table that have been moved to the team_settings table. I have updated the necessary scripts in seed-database/write.

Ran GH regression tests and all passed

[github-actions]

🤖 Hasura Change Summary compared a subset of table metadata including permissions:

Updated Tables (1)

• public.teams permissions:

  	insert	select	update	delete
  api		➕/➖
  platformAdmin	➕/➖	➕/➖	➕/➖
  public		➕/➖
  teamEditor		➕/➖

  23 removed column permissions

  	insert	select	update
  api		➖ boundary ➖ notify_personalisation ➖ reference_code ➖ settings ➖ submission_email
  platformAdmin	➖ boundary ➖ notify_personalisation ➖ settings ➖ submission_email	➖ boundary_bbox ➖ notify_personalisation ➖ reference_code ➖ settings	➖ notify_personalisation ➖ settings ➖ submission_email
  public		➖ boundary ➖ notify_personalisation ➖ reference_code ➖ settings
  teamEditor		➖ notify_personalisation ➖ reference_code ➖ settings

Untracked Tables (1)

• public.teams_summary

[github-actions]

Pizza

Deployed 93df80f to https://3636.planx.pizza.

Useful links:

• Editor
• Storybook
• Hasura
• API
• ShareDB

[RODO94]

Allow editors to see/update their team's submission email in "Team settings" form

[jessicamcinchak]

Two adjustments please!

• Can you please squash migrations into a single up.sql & down.sql ?
  • You can drop many columns at once on the same table like ALTER TABLE table DROP COLUMN col1, DROP COLUMN col2;
• Similar to comment on tidy: drop submission_email column from teams table and adjust seed-database/write script #3635, the order of commands in the down files are not currently valid - eg need to add a column before it can be commented on, altered etc

[DafyddLlyr]

Please also take a look at the migration files at planx-new/hasura.planx.uk/migrations/1692010483148_add_team_boundary - there's an orphaned boundary_bbox() function that should also be tidied up here now we're handling this on the frontend.

One thing to consider here - just updating db columns won't update the types directly. We'll also need a corresponding change in planx-core which removes these properties from the Team type (if they're present), and then import this type into the wider codebase to pick up any cascading changes. There is a chance that all tests are passing because types and mocks are unaware of the changes made in this PR.

[DafyddLlyr]

I think the computed field boundary_bbox is also redundant now right?

[DafyddLlyr]

Not sure where my previous comment went but this is still being incorrectly removed here.

[RODO94]

Sorry! That was in the submission email PR, but this is the exact same issue. Removing columns and not repointing the View creation. My bad for missing this again

[RODO94]

@DafyddLlyr for this one, if we merge my submission_email PR (#3640), I have already changed the references in the View creation, so this won't be an issue?

Could be a nice candidate to re-do this on a clean branch once #3640 is merged and reopen a new PR?

[RODO94]

Otherwise, I would be repeating code across the migrations