Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove submission_email column from teams table #3640

Merged
merged 3 commits into from
Sep 10, 2024
Merged

refactor: remove submission_email column from teams table #3640

merged 3 commits into from
Sep 10, 2024

Conversation

RODO94
Copy link
Contributor

@RODO94 RODO94 commented Sep 9, 2024 •
edited
Loading

What does this PR do?

To finish the work on https://trello.com/c/dVsTQpZZ/2984-allow-editors-to-see-update-their-teams-submission-email-in-team-settings-form

I have dropped the redundant column and adjusted the scripts which create the local DBs.

In order to keep the team_summary table, I had to adjust the sql code which creates it. From here I also repointed the homepage column of this table from teams table to team_settings table.

Up script running order:

  1. Change team_summary view using team_settings.submission_email column
  2. Remove teams.submission_email column

Down script:

  1. Add teams.submission_email column
  2. Replace team_summary view using new column

Regression tests passing

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024 •
edited
Loading

🤖 Hasura Change Summary compared a subset of table metadata including permissions:

Updated Tables (1)

  • public.teams permissions:

    insert select update delete
    api ➕/➖
    platformAdmin ➕/➖ ➕/➖
    3 removed column permissions
    insert select update
    api ➖ submission_email
    platformAdmin ➖ submission_email ➖ submission_email

@RODO94 RODO94 mentioned this pull request Sep 9, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@RODO94 RODO94 marked this pull request as ready for review September 9, 2024 09:44
@RODO94 RODO94 requested a review from a team September 9, 2024 09:44
DafyddLlyr
DafyddLlyr requested changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments!

...x.uk/migrations/1725873202035_alter_table_public_teams_drop_column_submission_email/down.sql Outdated Show resolved Hide resolved
...x.uk/migrations/1725873202035_alter_table_public_teams_drop_column_submission_email/down.sql Outdated Show resolved Hide resolved
...anx.uk/migrations/1725873202035_alter_table_public_teams_drop_column_submission_email/up.sql Show resolved Hide resolved
DafyddLlyr
DafyddLlyr approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect - thanks for making these changes!

@RODO94 RODO94 mentioned this pull request Sep 10, 2024
Closed
@RODO94 RODO94 merged commit a8f9c7c into main Sep 10, 2024
12 checks passed
@RODO94 RODO94 deleted the rory/drop-submission-column-v02 branch September 10, 2024 08:17
@RODO94
Copy link
Contributor Author

RODO94 commented Sep 10, 2024

Allow editors to see/update their team's submission email in "Team settings" form

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DafyddLlyr DafyddLlyr DafyddLlyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RODO94 @DafyddLlyr