-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable images in project description text #651
Conversation
✅ Deploy Preview for gatsby-theme-project-portal-defaults ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for project-portal-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for gatsby-theme-project-portal-ex-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Note: This comment gets updated with every commit f6dabe959ed743c53e90ad8906fb84b833292bfa example-site |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Joselynn, this looks great! Please could you add an example of an image being shown in the packages/example-site
site?
Ok I did this and the checks seem to be passing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test works great.
I had a look at some of the other collections – images are also set on the card pages and the other pages. Unfortunately, this change breaks the image display in those two places. There are a couple of options I can see.
It looks to me as though the handling of images on the whole – where they get stored, how they are divided up, and whether you can set images for the layout components from the CMS (you can't right now) – needs another look, but that's a different PR. It feels like, with this PR, we're getting the hang of handling images!
…ly apply to the project collection in cms.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Great!
This allows project pages to render images that are uploaded via netlify or stored in /static/image (see https://decapcms.org/docs/add-to-your-site/#app-file-structure)