Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Client refactor #1291

Merged
merged 11 commits into from
Mar 24, 2021
Merged

WIP: Client refactor #1291

merged 11 commits into from
Mar 24, 2021

Commits on Mar 24, 2021

  1. Add a refactored Updater.refresh() 

    A proposal of a new Updater.refresh() implementation:
    - based on metadata API
    - no longer dependent on keydb/roledb
    - follows the TUF specification's client workflow

Introduces a MetadataWrapper class with the goal of
providing functionality which is at this point missing
in metadata API.

Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
    @sechkova
    sechkova committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    c96cd64 View commit details
    Browse the repository at this point in the history

  2. Add targets download functionality to the new Updater 

    Mostly a transfer of the current client code related to
the actual target files download. Needs to be further
reworked.

Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
    @sechkova
    sechkova committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    1e52ccd View commit details
    Browse the repository at this point in the history

  3. Add tests and linter config to the new Updater 

    Adds a basic test case for Updater.
Applies the linter config used in api/metadata.py to all files
under client_rework.

Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
    @sechkova
    sechkova committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    f666a59 View commit details
    Browse the repository at this point in the history

  4. Temporary reduce code coverage to 90 percent 

    Coverage failures may hide other failing tests in the CI.
Configure coverage to fail under 90 percent during the
ongoing experimental-client development.

Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
    @sechkova
    sechkova committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    1fa7412 View commit details
    Browse the repository at this point in the history

  5. Add .gitattributes file 

    For compatibility with Windows systems, declare repository_data
files to always have LF line endings on checkout.

A trailing "/**" matches everything inside, with infinite depth.

Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
    @sechkova
    sechkova committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    8abe49a View commit details
    Browse the repository at this point in the history

  6. Update the tox lint environment 

    Apply the updated api/pylintrc config to the client_rework
directory.

Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
    @sechkova
    sechkova committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    c4b5eb5 View commit details
    Browse the repository at this point in the history

  7. Apply black and isort over the refactored client 

    Run manually the black and isort code formatters over
the client_rework code.

Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
    @sechkova
    sechkova committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    5edb58c View commit details
    Browse the repository at this point in the history

  8. Configure tox to run black over the new client code 

    Configure tox to run black and isort over the files
under client_rework directory.

Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
    @sechkova
    sechkova committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    2d48cf2 View commit details
    Browse the repository at this point in the history

  9. Fix various pylint issues 

    Fix linter issues after applying the api/pylintrc config
over the client_rework/* code.

Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
    @sechkova
    sechkova committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    ca1ff90 View commit details
    Browse the repository at this point in the history

  10. Disable exceptions related pylint checks 

    Temporary disable (inline) try-except-raise and broad-except
warnings in the new Updater code until client exception handling
is revised (theupdateframework#1312).

Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
    @sechkova
    sechkova committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    df6c319 View commit details
    Browse the repository at this point in the history

  11. Disable undefined-loop-variable checks 

    Temporary disable (inline) undefined-loop-variable pylint
checks in the new Updater code until the download functionality
is revised (theupdateframework#1307).

Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
    @sechkova
    sechkova committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    d472989 View commit details
    Browse the repository at this point in the history