Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use random service name in tests to avoid side effects from concurrent runs #2618

Merged

Conversation

reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Jan 23, 2024

Proposed changes

Improve system tests which used a fixed service name which would cause failures if another system test instance is running the same test (or the service is not cleaned up by the test).

Instead use a randomly generated service name to reduce risk of name clashes.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

…current runs

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller requested a review from a team as a code owner January 23, 2024 22:15
@reubenmiller reubenmiller added the theme:testing Theme: Testing label Jan 23, 2024
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
381 0 3 381 100 59m54.331s

@reubenmiller reubenmiller added this pull request to the merge queue Jan 24, 2024
Merged via the queue into thin-edge:main with commit d68f8dc Jan 24, 2024
18 checks passed
@reubenmiller reubenmiller deleted the test-use-random-service-names branch July 18, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:testing Theme: Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants