Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use unique child names when creating devices with an explicit @id field #2657

Merged

Conversation

reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Feb 1, 2024

Proposed changes

Use unique names within the system test which registers devices using an explicit @id field to avoid name clashes when running multiple tests or if the device is not cleaned up in Cumulocity IoT (as the @id is used as the External Id which must be unique within the whole tenant, and can only have 1 owner).

This is the same issue fixed in other tests in #2618

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

… field

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller requested a review from a team as a code owner February 1, 2024 21:01
@reubenmiller reubenmiller added the theme:testing Theme: Testing label Feb 1, 2024
Copy link
Contributor

github-actions bot commented Feb 1, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
389 0 3 389 100 50m12.272s

@reubenmiller reubenmiller added this pull request to the merge queue Feb 2, 2024
Merged via the queue into thin-edge:main with commit aece3c5 Feb 2, 2024
18 checks passed
@reubenmiller reubenmiller deleted the test-use-unique-child-names branch July 18, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:testing Theme: Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants