[SDK] Fix: Track chain ID on transaction events #5272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregfromstl
requested review from
jnsdls,
MananTank and
joaquim-verges
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 0391117 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
size-limit report 📦
|
jnsdls
requested changes
Nov 2, 2024
...dashboard/src/app/(dashboard)/dashboard/connect/in-app-wallets/[clientId]/analytics/page.tsx
Outdated
Show resolved
Hide resolved
gregfromstl
force-pushed
the
fix/track-chains
branch
2 times, most recently
from
4e94bec
to
0391117
Compare
gregfromstl
added
TS SDK
jnsdls
approved these changes
Nov 2, 2024
gregfromstl
added
the
merge-queue
Merge activity
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5272 +/- ##
==========================================
- Coverage 45.37% 45.36% -0.01%
==========================================
Files 1067 1067
Lines 55446 55449 +3
Branches 3989 3989
==========================================
Hits 25157 25157
- Misses 29598 29601 +3
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more.
|
Fixes [CNCT-2184](https://linear.app/thirdweb/issue/CNCT-2184) <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces modifications to the `trackTransaction` function across multiple files in the `thirdweb` package, adding support for `chainId` in transaction tracking. ### Detailed summary - Added `chainId: tx.chainId` to `trackTransaction` in: - `packages/thirdweb/src/wallets/injected/index.ts` - `packages/thirdweb/src/wallets/in-app/core/wallet/enclave-wallet.ts` - `packages/thirdweb/src/wallets/in-app/web/lib/iframe-wallet.ts` - `packages/thirdweb/src/wallets/coinbase/coinbaseWebSDK.ts` - `packages/thirdweb/src/wallets/wallet-connect/controller.ts` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
fix/track-chains
branch
from
0391117
to
e3c0af2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CNCT-2184
PR-Codex overview
This PR focuses on adding
chainIdtracking to various transaction handling functions across multiple files in thethirdwebpackage.Detailed summary
chainId: tx.chainIdtotrackTransactioncalls in:packages/thirdweb/src/wallets/injected/index.tspackages/thirdweb/src/wallets/in-app/core/wallet/enclave-wallet.tspackages/thirdweb/src/wallets/in-app/web/lib/iframe-wallet.tspackages/thirdweb/src/wallets/coinbase/coinbaseWebSDK.tspackages/thirdweb/src/wallets/wallet-connect/controller.ts