Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Fix: Track chain ID on transaction events #5272

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Commits on Nov 2, 2024

  1. [SDK] Fix: Track chain ID on transaction events (#5272)

    Fixes [CNCT-2184](https://linear.app/thirdweb/issue/CNCT-2184)
    
    <!-- start pr-codex -->
    
    ---
    
    ## PR-Codex overview
    This PR introduces modifications to the `trackTransaction` function across multiple files in the `thirdweb` package, adding support for `chainId` in transaction tracking.
    
    ### Detailed summary
    - Added `chainId: tx.chainId` to `trackTransaction` in:
      - `packages/thirdweb/src/wallets/injected/index.ts`
      - `packages/thirdweb/src/wallets/in-app/core/wallet/enclave-wallet.ts`
      - `packages/thirdweb/src/wallets/in-app/web/lib/iframe-wallet.ts`
      - `packages/thirdweb/src/wallets/coinbase/coinbaseWebSDK.ts`
      - `packages/thirdweb/src/wallets/wallet-connect/controller.ts`
    
    > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
    
    <!-- end pr-codex -->
    gregfromstl committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    e3c0af2 View commit details
    Browse the repository at this point in the history