Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only remove modules that are not *.node from the cache #109

Closed
wants to merge 1 commit into from
Closed

Only remove modules that are not *.node from the cache #109

wants to merge 1 commit into from

Conversation

hsablonniere
Copy link

Removing a *.node module from the cache and requiring it a 2nd time causes an Error :
Error: Module did not self-register.

See nodejs/node#5016

Fixes #108.

Removing a *.node module from the cache and requiring it a 2nd time causes an Error :
Error: Module did not self-register.

See nodejs/node#5016
@hsablonniere
Copy link
Author

Let me know if you want me to add some more tests specific for this.

@bertrandgressier
Copy link

👍

@bendrucker
Copy link
Collaborator

Would love a test before merging this @hsablonniere

@bendrucker
Copy link
Collaborator

Are you able to add a test? The behavior is okay until Node can allow us to reintroduce cache manipulation support for modules with native deps.

@hsablonniere
Copy link
Author

Hey Ben,

I don't have much time these days to get back on this. Feel free to tag it and to close it.

Thx ;-)

@bendrucker bendrucker closed this Nov 27, 2016
@sonicdoe
Copy link
Contributor

I would like to add a test for this. @bendrucker Would you rather have a test which actually requires a native module or one which just fakes an item in require.cache?

@bendrucker
Copy link
Collaborator

A real world integration test would be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants