Only remove non-native modules from cache #149
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #109 and #108, we should only remove non-native modules from the cache because, upon requiring a native module a second time, it causes a “Module did not self-register” error (see nodejs/node#5016).
I thought about adding a similar check to
_withoutCache
whennoPreserveCache()
is used but I’m not sure if that’s desirable because it conveys the idea that native modules can be cleared from cache. Maybe we should add a note explaining thatnoPreserveCache()
shouldn’t be used when stubbing native modules?