Add heterogeneous helper functions and restructure internals
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomashoneyman
commented
Oct 19, 2018
src/Spec/Retrieve.purs
Outdated
|
|
||
| -- | A type representing retrieving all of a particular field with the field's | ||
| -- | constructor name. For internal use. | ||
| type GetAll f = |
There was a problem hiding this comment.
@dariooddenino Your version of this is prettier and the type signatures are more immediately obvious in explaining what the function does (getInputs :: FormFieldGetFields "input"). However, I'm trying to minimize the number of constraints (especially RowToList ones) wherever possible for compile-time performance reasons. This version is less nice, but has fewer constraints.
…ucture modules to more accurately reflect names and uses of functions and for clarity.
* Added helper queries for all public queries. Added SetAll and ModifyAll functions. Broke something... * Fix instances * Update examples. Rename replaceInputs to initialize to better reflect its purpose and function. * Fix formatting * Add wrapInputFunctions helper function. Add documentation to wrap* and unwrap* helpers.
Add ability to set or modify input values, instead of only set.
|
Updates to support |
|
Will merge and release 0.3.0 on Monday, with a migration guide, unless there are any objections. (cc: @whoadave @crcornwell @dariooddenino) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Provides a solution for #18 and #19 by adding helper functions based on
heterogeneous. Also restructures some internals and classes to minimize the number of constraints that exist on the Formless component to save some compile times.Unfortunately, pending some resolution in the Heterogeneous library (see: natefaubion/purescript-heterogeneous#2), no heterogeneous constraints can be placed on the Formless component without breaking the library, so all changes directly on the component have had to be reverted.
Still, a number of new helper functions are available and the exercise cleaned up the internals of the library.
How should this be manually tested?
Verify that the example components still work as expected.
Other Notes:
This PR changes the namespaces of several functions, and if users are not importing from the main Formless module, they will see breaking changes. However, existing functionality has been maintained. If users are importing from the main Formless module, then this change will have no effect on their code.