Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Selenium "options" deprecation #2118

Merged

Conversation

jordan-brough
Copy link
Contributor

Silences this warning while running "bundle exec rspec":

WARN Selenium [DEPRECATION] [:browser_options] :options as a parameter for
driver initialization is deprecated. Use :capabilities with an Array of
value capabilities/options if necessary instead.

Silences this warning while running "bundle exec rspec":

    WARN Selenium [DEPRECATION] [:browser_options] :options as a parameter for
    driver initialization is deprecated. Use :capabilities with an Array of
    value capabilities/options if necessary instead.
@jordan-brough jordan-brough force-pushed the selenium-options-deprecation branch from 6bba8d0 to 825139b Compare January 24, 2022 18:32
@jordan-brough
Copy link
Contributor Author

@nickcharlton thanks for merging #2124! I've rebased this on latest main to resolve the merge conflicts.

I see you also merged #2064 (cc @pablobm). This PR is another way to avoid the warnings, while still maintaining the perhaps "nicer"(?) api for configuring the options. I don't think there's anything different other than the syntax, so feel free to close this PR if you want to just stick with what's in main now.

@nickcharlton
Copy link
Member

I think on balance, I prefer the way this looks and I often find I (and presumably others) copy out the config so if we've got a better option I'm going to go with it!

Thanks!

@nickcharlton nickcharlton merged commit 441337f into thoughtbot:main Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants