Un-pin capybara gem #2124
Merged
Un-pin capybara gem #2124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-brough
force-pushed
the
unpin-capybara
branch
from
9894e7b to
fb644af
Compare
Several years ago in PR 1245 this was pinned with this message: > Pin the capybara gem, until we can drop Ruby 2.2.0 > Any capybara versions above 3.0.0 require a newer Ruby than 2.2.0, which > we will support in line with Rails requirements. Ruby 2.2 support has been dropped, so I think we can drop the pinning now? It doesn't really do much at this point anyway since dependabot is automatically updating to the lastest versions soon after they are released.
nickcharlton
force-pushed
the
unpin-capybara
branch
from
fb644af to
0a3a450
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several years ago in #1245
capybarawas pinned with this message:Ruby 2.2 support has been dropped, so I think we can drop the pinning now?
It doesn't really do much at this point anyway since dependabot is automatically
updating to the lastest versions soon after they are released.
Note: Merging this will probably generate some conflicts for #2118, or vice versa.
If one of the PRs gets merged I'll update the other.