Update has_many.rb

[jubilee2]

disable paginate for has_many field

solve #2271

[tancrede]

Hi jubilee2,

Thanks for the proposal. If my understanding of your code is correct, this change would allow something like this ?

ATTRIBUTE_TYPES = {
    names: Field::HasMany.with_options(paginate: false),
  }.freeze

[jubilee2]

Yes, It is correct!

[pablobm]

How about making it work with limit: false instead?

[tancrede]

that would be a little more natural

[jubilee2]

      def paginate?
        limit != false 
      end

[pablobm]

@jubilee2 - I think that's right. What do you think? Would you be up for modifying your PR?

[jubilee2]

@pablobm

can you help me update the document? Thanks!

[pablobm]

Sorry for the long delay. Let's see if we can get this merged!

[pablobm]

Remember to remove this trailing space 🙂

[jubilee2]

Sorry for the long delay. Let's see if we can get this merged!

resolved

[tancrede]

Thank you @ALL for this evolution.

[pablobm]

By the way, a bug was introduced here. It should have surfaced in CI but somehow it didn't 🤔 Oh well.

I have created #2289 to fix this. Currently waiting for a fellow maintainer to review.

[jubilee2]

not sure the CI not trigger on PR... take look into nonzero

[jubilee2]

#2296 should fix issue