Fix behaviour of has_many pagination #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 24, 2022
Merged
|
Closing in favour of #2296 |
|
Misunderstood #2296. I thought it was a PR on main, but it was on this branch. Reopening to squash and merge. |
No idea of how I could merge this. Didn't CI fail? It definitely did after merging it.
pablobm
force-pushed
the
fix-hasmany-pagination
branch
from
05eae82 to
28dad93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bad behaviour introduced in #2274.
No idea of how I could merge that then. Didn't CI fail? It definitely did after merging it.