Fix backward compatible Pundit include #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbuys
force-pushed
the
fbuys/2378-fix-uninitialized-constant
branch
2 times, most recently
from
3575d34 to
846cd19
Compare
fbuys
commented
May 23, 2023
| if Pundit.const_defined?(:Authorization) | ||
| include Pundit::Authorization | ||
| else | ||
| include Pundit |
There was a problem hiding this comment.
This includes was deprecated in 2.2.0: https://github.com/varvet/pundit/blob/main/CHANGELOG.md#deprecated
fbuys
force-pushed
the
fbuys/2378-fix-uninitialized-constant
branch
from
846cd19 to
8728917
Compare
fbuys
commented
May 24, 2023
|
We appear to be having CI issues 😓 I'll merge after we solve them. |
|
CI should be fixed in master now. Can you try rebase, please? |
This commit fixes: thoughtbot#2378 By adding a conditional that includes Pundit::Authorization when it is defined else it includes Pundit. This change ensures that we remain compatible with Pundit < 2.2.0 To test with Pundit "~> 2.1.0", we run: ``` bundle exec appraisal pundit21 rspec spec/controllers/concerns/administrate/punditize_spec.rb ``` See: thoughtbot#2141 See: thoughtbot#1068
fbuys
force-pushed
the
fbuys/2378-fix-uninitialized-constant
branch
from
8728917 to
1a4147b
Compare
No problem, I have rebased and pushed again ✅ |
|
Great stuff! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #2378 By adding a conditional that includes Pundit::Authorization when it is defined else it includes Pundit.
This change ensures that we remain compatible with Pundit < 2.2.0
To test with Pundit "~> 2.1.0", we run:
See: #2141
See: #1068