Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add it locale #297

Closed
wants to merge 3 commits into from
Closed

add it locale #297

wants to merge 3 commits into from

Conversation

masciugo
Copy link
Contributor

@masciugo masciugo commented Dec 6, 2015

No description provided.

@masciugo
Copy link
Contributor Author

masciugo commented Dec 8, 2015

about the error

  1) I18n does not have missing keys
     Failure/Error: expect(missing_keys).to be_empty,
       Missing 11 i18n keys, run `i18n-tasks missing' to show them
     # ./spec/i18n_spec.rb:10:in `block (2 levels) in <top (required)>'

with

masciugo@macbookpro ~/dev/administrate $ i18n-tasks missing
Missing translations (7) | i18n-tasks v0.8.7
+--------+-----------------------------------------------+------------------------------------------------------------+
| Locale | Key                                           | Value in other locales or source                           |
+--------+-----------------------------------------------+------------------------------------------------------------+
|  all   | administrate.actions.confirm                  | app/views/administrate/application/_collection.html.erb:69 |
|  all   | administrate.actions.destroy                  | app/views/administrate/application/_collection.html.erb:65 |
|  all   | administrate.actions.edit                     | app/views/administrate/application/_collection.html.erb:59 |
|  all   | administrate.fields.has_many.more             | app/views/fields/has_many/_show.html.erb:30                |
|  all   | administrate.fields.has_many.none             | app/views/fields/has_many/_show.html.erb:39                |
|  all   | administrate.fields.has_one.not_supported     | app/views/fields/has_one/_form.html.erb:22                 |
|  all   | administrate.fields.polymorphic.not_supported | app/views/fields/polymorphic/_form.html.erb:23             |
+--------+-----------------------------------------------+------------------------------------------------------------+

I would add the missing keys entrusting the english ones which are missing too..

@@ -0,0 +1,23 @@
---
en:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line needs to be changed to in:. This might be what's causing the errors on CircleCI.

@masciugo
Copy link
Contributor Author

masciugo commented Dec 8, 2015

ya! thanks

@c-lliope
Copy link
Contributor

c-lliope commented Dec 9, 2015

Grazie!

Can anyone from the community verify this?

@marcolong
Copy link

if you mean correctness of Italian language for me is ok :)

@c-lliope
Copy link
Contributor

Merged this in as 5478293. Thanks!

@c-lliope c-lliope closed this Dec 11, 2015
c-lliope added a commit that referenced this pull request Jan 22, 2016
Changes:

```
* [#269] [FEATURE] Add a generator for copying default layout files
* [#328] [FEATURE] Add a generator for copying default sidebar partial
* [#362] [FEATURE] Add a generator for only the dashboard manifest.
  Customizing this manifest before running the `administrate:install` generator
  will change which dashboards get generated.
* [#295] [FEATURE] Add dashboard detection for ActiveRecord::Enum fields.
* [#364] [FEATURE] Improve dashboard generator by explicitly listing out the
  generated `SHOW_PAGE_ATTRIBUTES` array elements.
* [#416] [UI] Add an accessibility label to the search input
* [#411] [UI] Use tabular figures in table cells
* [#409] [UI] Use default system fonts
* [#424] [BUGFIX] Fix a bug where running `rails destroy GENERATOR_NAME`
  would not work for several of the generators
* [#390] [BUGFIX] Fix timestamp deprecation warnings
* [#365] [COMPAT] Remove dependency on `inline_svg`
* [#396] [I18n] Ukrainian
* [#297] [I18n] Italian
* [#307] [I18n] Fix German grammatical errors
* [#363] [DOC] Move documentation into main repository, at the root URL
* [#395] [DOC] Update inline documentation for collection partial
* [#387] [DOC] Fix incorrect path for generators in the docs
```
@c-lliope c-lliope mentioned this pull request Jan 22, 2016
c-lliope added a commit that referenced this pull request Jan 22, 2016
Changes:

```
* [#269] [FEATURE] Add a generator for copying default layout files
* [#328] [FEATURE] Add a generator for copying default sidebar partial
* [#362] [FEATURE] Add a generator for only the dashboard manifest.
  Customizing this manifest before running the `administrate:install` generator
  will change which dashboards get generated.
* [#295] [FEATURE] Add dashboard detection for ActiveRecord::Enum fields.
* [#364] [FEATURE] Improve dashboard generator by explicitly listing out the
  generated `SHOW_PAGE_ATTRIBUTES` array elements.
* [#416] [UI] Add an accessibility label to the search input
* [#411] [UI] Use tabular figures in table cells
* [#409] [UI] Use default system fonts
* [#424] [BUGFIX] Fix a bug where running `rails destroy GENERATOR_NAME`
  would not work for several of the generators
* [#390] [BUGFIX] Fix timestamp deprecation warnings
* [#365] [COMPAT] Remove dependency on `inline_svg`
* [#396] [I18n] Ukrainian
* [#297] [I18n] Italian
* [#307] [I18n] Fix German grammatical errors
* [#363] [DOC] Move documentation into main repository, at the root URL
* [#395] [DOC] Update inline documentation for collection partial
* [#387] [DOC] Fix incorrect path for generators in the docs
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants