Add a generator for the sidebar #328
Conversation
| expected_contents = contents_for_application_template("_sidebar") | ||
|
|
||
| run_generator [] | ||
| contents = File.read(file("app/views/admin/application/_sidebar.html.erb")) |
|
acrogenesis, thanks! I merged in #269 yesterday, which has a lot of overlap with this. I think there's room for both of: I think we'll want to change the layout generator so it calls this generator, instead of duplicating the logic. If you want to look into this, great! Otherwise I can take care of this when I merge it. |
|
I'm not entirely sure how to invoke the generator from the LayoutGenerator I'm trying to do it calling |
acrogenesis
force-pushed
the
sidebar-generator
branch
from
4e89f4f to
ab7f1a7
Compare
|
Yep, that's the right way to do it. The tests won't execute the sub-generator, so you'll have to stub it like I did here: administrate/spec/generators/assets_generator_spec.rb Lines 13 to 15 in 7e8943d (note the |
| contents = File.read(generated_file) | ||
|
|
||
| expect(contents).to eq(expected_contents) | ||
| expect(Rails::Generators).to invoke_generator("administrate:views:sidebar") |
|
thanks! I've updated the generator and tests. I also added the |
|
Great, thanks! I'll review this in more detail in the morning, and get it merged in as soon as I can! |
| @@ -15,6 +15,10 @@ def contents_for_application_template(view_name) | |||
| ) | |||
| end | |||
|
|
|||
| def invoke_generator(*args) | |||
| have_received(:invoke).with(*args) | |||
| end | |||
|
This looks good! I'll shuffle the lines around so they're < 80 characters, and merge this in. |
|
Merged in as 04ee51c. Thanks! |
Changes: ``` * [#269] [FEATURE] Add a generator for copying default layout files * [#328] [FEATURE] Add a generator for copying default sidebar partial * [#362] [FEATURE] Add a generator for only the dashboard manifest. Customizing this manifest before running the `administrate:install` generator will change which dashboards get generated. * [#295] [FEATURE] Add dashboard detection for ActiveRecord::Enum fields. * [#364] [FEATURE] Improve dashboard generator by explicitly listing out the generated `SHOW_PAGE_ATTRIBUTES` array elements. * [#416] [UI] Add an accessibility label to the search input * [#411] [UI] Use tabular figures in table cells * [#409] [UI] Use default system fonts * [#424] [BUGFIX] Fix a bug where running `rails destroy GENERATOR_NAME` would not work for several of the generators * [#390] [BUGFIX] Fix timestamp deprecation warnings * [#365] [COMPAT] Remove dependency on `inline_svg` * [#396] [I18n] Ukrainian * [#297] [I18n] Italian * [#307] [I18n] Fix German grammatical errors * [#363] [DOC] Move documentation into main repository, at the root URL * [#395] [DOC] Update inline documentation for collection partial * [#387] [DOC] Fix incorrect path for generators in the docs ```
Changes: ``` * [#269] [FEATURE] Add a generator for copying default layout files * [#328] [FEATURE] Add a generator for copying default sidebar partial * [#362] [FEATURE] Add a generator for only the dashboard manifest. Customizing this manifest before running the `administrate:install` generator will change which dashboards get generated. * [#295] [FEATURE] Add dashboard detection for ActiveRecord::Enum fields. * [#364] [FEATURE] Improve dashboard generator by explicitly listing out the generated `SHOW_PAGE_ATTRIBUTES` array elements. * [#416] [UI] Add an accessibility label to the search input * [#411] [UI] Use tabular figures in table cells * [#409] [UI] Use default system fonts * [#424] [BUGFIX] Fix a bug where running `rails destroy GENERATOR_NAME` would not work for several of the generators * [#390] [BUGFIX] Fix timestamp deprecation warnings * [#365] [COMPAT] Remove dependency on `inline_svg` * [#396] [I18n] Ukrainian * [#297] [I18n] Italian * [#307] [I18n] Fix German grammatical errors * [#363] [DOC] Move documentation into main repository, at the root URL * [#395] [DOC] Update inline documentation for collection partial * [#387] [DOC] Fix incorrect path for generators in the docs ```
I needed to edit the sidebar and noticed there wasn't a generator so I created one.
Run
To generate it, already verified on my app it works and tests are ✅