Stub out sidebar generator in layout gen tests #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When the layout generator invokes the sidebar generator, the tests do not recognize the file created by the sidebar generator, and the file does not get cleaned up after the test. Solution: Stub out the invocation of the sidebar generator when we're testing the layout generator.
c-lliope
force-pushed
the
gw-cleanup-gen-tests
branch
from
ac45b74 to
2499efd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #328.
Problem:
When the layout generator invokes the sidebar generator,
the tests do not recognize the file created by the sidebar generator,
and the file does not get cleaned up after the test.
Solution:
Stub out the invocation of the sidebar generator
when we're testing the layout generator.