Fix UI regressions #408
Merged
Fix UI regressions #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately... we've already run through our Percy quota for this month, so we can't automatically verify that these fixes are valid. |
This was referenced Jan 14, 2016
| @@ -3,6 +3,7 @@ | |||
| max-width: 12em; | |||
| overflow-y: auto; | |||
| padding: 0 $base-spacing; | |||
| padding-bottom: $base-spacing; | |||
There was a problem hiding this comment.
This addition means we are defining padding twice. Line 5 applies 0 to the padding-bottom, and Line 6 we overwrite that.
Instead, we can just update Line 5 to; padding: 0 $base-spacing $base-spacing;
|
One minor comment, otherwise 👍 |
Problem: When merging in #198, the Percy.io visual regression tests weren't run because our quota for the month had been used up. Because we did not have the assurance of visual regression tests, we didn't realize that the `:last-child` selector that we applied to sidebar links actually applied to all of the sidebar links, because each was wrapped in their own `<li>` parent. This increased the spacing between the links above what we wanted. Solution: Move the padding from the last link onto its parent element, the sidebar `<ul>` element.
Problem: When merging in #214, the Percy.io visual regression tests weren't run because our quota for the month had been used up. In that PR, we re-aligned the button in the header. This change accidentally affected content below the header. Solution: Change the alignment from `baseline` to `flex-start`. This keeps the button from affecting content below the header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging in #198 and #214,
the Percy.io visual regression tests weren't run
because our quota for the month had been used up.
Without the visual regression tests,
we failed to notice two visual regressions that were introduced.
The two commits in this PR fix the visual regressions that were introduced.
See the commit descriptions for more information.