Prevent white-space from appearing above header button when title is unusually long #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@murdoch this looks great! Can you do me a favor and rebase on master? We've added some visual regression tests to make sure CSS changes don't accidentally break things. I'm sure you're fine here, but just want to get into the habit. After that, should be good to merge! |
|
Also, I think @smharley and @devonharless, thoughts on |
|
My only other feedback is that it would be nice to have some |
|
Merged in as 67d8704. Thanks! |
c-lliope
added a commit
that referenced
this pull request
Dec 9, 2015
Changes: ``` * [#251] [FEATURE] Raise a helpful error when an attribute is missing from `ATTRIBUTE_TYPES` * [#298] [FEATURE] Support ActiveRecord model I18n translations * [#312] [FEATURE] Add a `nil` option to `belongs_to` form fields * [#231] [UI] Fix layout issue on show page where a long label next to an empty value would cause following fields on the page to be mis-aligned. * [#309] [UI] Fix layout issue in datetime pickers where months and years would not wrap correctly. * [#306] [UI] Wrap long text lines (on word breaks) on show pages * [#214] [UI] Improve header layout when there is a long page title * [#198] [UI] Improve spacing around bottom link in sidebar * [#206] [UI] Left-align checkboxes in boolean form fields * [#315] [UI] Remove the `IDS` suffix for `HasMany` form field labels * [#259] [BUGFIX] Make installation generator more robust by ignoring dynamically generated, unnamed models * [#243] [BUGFIX] Fix up a "Show" button on the edit page that was not using the `display_resource` method. * [#248] [BUGFIX] Improve polymorphic relationship's dashboard class detection. * [#247] [BUGFIX] Populate `has_many` and `belongs_to` select boxes with the current value of the relationship. * [#217] [I18n] Dutch * [#263] [I18n] Swedish * [#272] [I18n] Danish * [#270] [I18n] Don't apologize about missing relationship support. * [#237] [I18n] Fix broken paths for several I18n files (de, es, fr, pt-BR, vi). * [#266] [OPTIM] Save a few database queries by using cached counts ```
c-lliope
added a commit
that referenced
this pull request
Jan 14, 2016
Problem: When merging in #214, the Percy.io visual regression tests weren't run because our quota for the month had been used up. In that PR, we re-aligned the button in the header. This change accidentally affected content below the header. Solution: Change the alignment from `baseline` to `flex-start`. This keeps the button from affecting content below the header.
Merged
c-lliope
added a commit
that referenced
this pull request
Jan 15, 2016
Problem: When merging in #214, the Percy.io visual regression tests weren't run because our quota for the month had been used up. In that PR, we re-aligned the button in the header. This change accidentally affected content below the header. Solution: Change the alignment from `baseline` to `flex-start`. This keeps the button from affecting content below the header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I visit the edit page for a resource with a long title I notice some unsightly white-space above the show page link that appears next to the h1 tag. See image:
This whitespace is caused by the following CSS:
To get rid of this white-space we can change flex-end to flex-start or baseline, see below:
I will understand if you prefer flex-start over baseline.