-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract image field into a separate gem #476
Conversation
f1654e2
to
e3006d5
Compare
@jferris mind if I get your eyes? I'm having some trouble figuring out the right strategy to publish this feature. This repository contains both the In turn, the Here's the best plan I can come up with:
What do you think? Any changes that you'd make? I'm also not sure what would happen if we set Thanks for your help! |
Feature: **When I** have a custom field type that I want to share with others, **I want to** reference an official template for a field gem **so I can** more easily package my field for sharing. Implementation: Create a template for field plugins by extracting the image field into its own gem. This is a breaking change with an easy fix - anybody who uses Image fields will need to add `gem "administrate-field-image"` to their `Gemfile`. The source for the image field gem is up at https://github.com/graysonwright/administrate-field-image.
1fb82f8
to
0e78203
Compare
From http://guides.rubygems.org/patterns/#pessimistic-version-constraint:
|
4b0ddfa
to
d69b148
Compare
Problem: This repository contains both the administrate gem and the demo application. The demo application uses the image field, which means that its Gemfile will be dependent on the new administrate-field-image gem. In turn, the administrate-field-image gem is dependent on the administrate gem in this repository. This creates a little bit of a chicken-and-egg problem for publishing both of those gems. Solution: Our release plan is as follows: - Release this branch as a new version of the administrate gem, as version `0.2.0.rc1` - Make administrate-field-image dependent on `"administrate", "0.2.0.rc1", "~> 0.2.0"` - Release administrate-field-image v `0.0.1` - Make the demo app's Gemfile dependent on `"administrate-field-image", "~> 0.0"` - Re-push this branch to Github to run CircleCI suite. All of the gems would be available on rubygems.org, so the suite should pass. - Update and release this branch as version `0.2.0` - Merge branch
d69b148
to
53457a6
Compare
Feature:
When I have a custom field type that I want to share with others,
I want to reference an official template for a field gem
so I can more easily package my field for sharing.
Implementation:
Create a template for field plugins
by extracting the image field into its own gem.
This is a breaking change with an easy fix -
anybody who uses Image fields
will need to add
gem "administrate-field-image"
to theirGemfile
.The source for the image field gem is up at
https://github.com/graysonwright/administrate-field-image.