Support nested forms for has_many relationships #546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #192 Feature: When I create or edit a model that has_many nested models, I want to view and edit the attributes of the nested models so I can set up all the relationships with a single form. Implementation: Introduce a new field type, `NestedHasMany`. I considered building the feature into the existing `HasMany` field, but this would get in the way of `HasMany` relationships that aren't directly nested, such as in many-to-many relationships. The `NestedHasMany` field builds off of the [Cocoon] gem. It renders fields from the nested model, based on the fields defined in the nested model's dashboard class. Cocoon provides helpers and javascript to easily add and remove nested form fields from the page. [Cocoon]: https://github.com/nathanvda/cocoon
| def self.permitted_attribute(associated_resource) | ||
| { | ||
| "#{associated_resource}_attributes".to_sym => | ||
| associated_attributes(associated_resource) |
There was a problem hiding this comment.
Put a comma after the last item of a multiline hash.
| @@ -24,6 +24,7 @@ Gem::Specification.new do |s| | |||
| s.add_dependency "rails", "~> 4.2" | |||
| s.add_dependency "sass-rails", "~> 5.0" | |||
| s.add_dependency "selectize-rails", "~> 0.6" | |||
| s.add_dependency "cocoon", "~> 1.2" | |||
There was a problem hiding this comment.
🔤 this into the existing list?
|
In #476, we decided on a plugin structure for new field types. Nested It's rough but functional. PRs are welcome on that repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #192
Feature:
When I create or edit a model that has_many nested models,
I want to view and edit the attributes of the nested models
so I can set up all the relationships with a single form.
Implementation:
Introduce a new field type,
NestedHasMany.I considered building the feature into the existing
HasManyfield,but this would get in the way of
HasManyrelationshipsthat aren't directly nested, such as in many-to-many relationships.
The
NestedHasManyfield builds off of the Cocoon gem.It renders fields from the nested model,
based on the fields defined in the nested model's dashboard class.
Cocoon provides helpers and javascript
to easily add and remove nested form fields from the page.
Preview
Next Steps