Abstract model classes should be skipped without warning. #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I’ve also clarified the existing specs by including an assertion against the presence of a warning, so the name of the spec matches what is actually being tested.
| it 'skips abstract models without a warning' do | ||
| stub_generator_dependencies | ||
| routes = file("config/routes.rb") | ||
|
|
|
@lukeredpath totally want to get this merged. Can you rebase and squash 8e945d6 and 4551dc6 into a single commit? You could also use heredocs to help shorten the strings; or multilines with |
|
@lukeredpath Just wanted to check in on this one.. Would you be able to take care of the feedback from above? We'd love to get this one merged. Thanks! |
|
@lukeredpath Could I get you to fix up the Hound warnings on this and rebase? Or alternatively, enable contributor pushes? |
|
I'm going to close this as I've rebased myself and opened #857. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve also clarified the existing specs by including an assertion against the presence of a warning, so the name of the spec matches what is actually being tested.
I'm not 100% happy with checking against an exact match on the warning text but it seemed important to check for the presence (or absence) of a warning.
This is related to #581 but I'm not sure its the only issue I'm having with this generator on Rails 5.