Abstract model classes should be skipped without warning. #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are failing because we removed DelayedJob in #845. We can probably make an |
Merged
houndci-bot
reviewed
May 8, 2017
| output = run_generator | ||
|
|
||
| expect(routes).not_to contain("abstract_model") | ||
| expect(output).not_to include("WARNING: Unable to generate a dashboard for AbstractModel") |
|
|
||
| expect(routes).not_to contain("model_without_db_table") | ||
| expect(output).to include("WARNING: Unable to generate a dashboard for ModelWithoutDBTable") |
I’ve also clarified the existing specs by including an assertion against the presence of a warning, so the name of the spec matches what is actually being tested. Use shortened syntax and strip whitespace.
BenMorganIO
reviewed
May 9, 2017
|
|
||
| output = run_generator | ||
|
|
||
| expect(routes).not_to contain("abstract_model") |
There was a problem hiding this comment.
Shouldn't this always pass since you load up the routes file before running the generator?
iarie
pushed a commit
to iarie/administrate
that referenced
this pull request
Jun 17, 2017
…#857) I’ve also clarified the existing specs by including an assertion against the presence of a warning, so the name of the spec matches what is actually being tested. Use shortened syntax and strip whitespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #582.