Fix I18n translation for attributes in has_many collections #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spec/features/show_page_spec.rb
Outdated
| edit: 'Edit', | ||
| destroy: 'Destroy', | ||
| confirm: 'Are you sure?' | ||
| } |
There was a problem hiding this comment.
Put a comma after the last item of a multiline hash.
|
Thanks @hughfm don't forget to fix the hound warnings :) |
|
Thanks @BenMorganIO I'm still a bit new to this :) I've just fixed those up, should I just push an extra commit onto this branch? |
|
Cool. Can you rebase and squish them into a single commit? I'll get them merged on in after :) |
|
thanks @BenMorganIO that's all done, but not sure why CI has failed now - let me know if there's an issue, cheers. |
|
Hi guys, any updates here? It seems to be still an issue in current master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Following on from changes in #492...
When collection partials are rendered in the context of a
has_manyfield, translations for the attribute labels are currently being looked up under the parent model's scope. For example, label forshipped_atattribute onOrdermodel is looking inen: helpers: label: customer: shipped_at:, rather thanen: helpers: label: order: shipped_at:Solution:
Use
collection_presenter.resource_name, which is scoped to the field being rendered, instead ofresource_name.