Use I18n translations for custom labels on dashboards #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-lliope
force-pushed
the
gw-custom-labels
branch
from
2e3cf72 to
47e2fc4
Compare
| cell-label--<%= collection_presenter.ordered_html_class(attr_name) %> | ||
| <th class="cell-label | ||
| cell-label--<%= attr_type.html_class %> | ||
| cell-label--<%= collection_presenter.ordered_html_class(attr_name) %> |
There was a problem hiding this comment.
Unrelated change: improve spacing of a super-long HTML tag
c-lliope
changed the title
c-lliope
force-pushed
the
gw-custom-labels
branch
from
68cba4d to
4ad2eb2
Compare
|
@mcmire, can I get a review? Thanks! |
Problem:
At the moment, developers can customize a field's label on form pages
with the following translation structure:
```
en:
helpers:
label:
customer:
name: Full Name
```
Many developers expect this label change to take effect
on the `show` and `index` pages, as well as the form page.
Solution:
Translate attribute labels with I18n before displaying them
on `show` and `index` pages.
c-lliope
added a commit
that referenced
this pull request
May 18, 2016
Changes: * [#573] [FEATURE] Render custom javascripts and stylesheets to the page by registering them with Administrate in an initializer. For example, you can create `config/initializers/administrate.rb` with the contents: ``` Administrate::Engine.add_javascript "my_plugin/script" Administrate::Engine.add_stylesheet "my_plugin/styles" ``` * [#567] [FEATURE] Add a partial for rendering HTML links to stylesheets. This is useful for plugin developers, as well as people who want to add custom stylesheets on a page-by-page basis using `content_for(:stylesheet)`. * [#492] [FEATURE] Translate attribute labels on show and index pages. To customize an attribute label, add translations according to the structure: ``` en: helpers: label: customer: name: Full Name ```
Merged
|
Administrate already use |
heyogrady
pushed a commit
to heyogrady/administrate
that referenced
this pull request
Sep 6, 2016
Changes: * [thoughtbot#573] [FEATURE] Render custom javascripts and stylesheets to the page by registering them with Administrate in an initializer. For example, you can create `config/initializers/administrate.rb` with the contents: ``` Administrate::Engine.add_javascript "my_plugin/script" Administrate::Engine.add_stylesheet "my_plugin/styles" ``` * [thoughtbot#567] [FEATURE] Add a partial for rendering HTML links to stylesheets. This is useful for plugin developers, as well as people who want to add custom stylesheets on a page-by-page basis using `content_for(:stylesheet)`. * [thoughtbot#492] [FEATURE] Translate attribute labels on show and index pages. To customize an attribute label, add translations according to the structure: ``` en: helpers: label: customer: name: Full Name ```
fwolfst
pushed a commit
to fwolfst/administrate
that referenced
this pull request
Mar 8, 2017
Changes: * [thoughtbot#573] [FEATURE] Render custom javascripts and stylesheets to the page by registering them with Administrate in an initializer. For example, you can create `config/initializers/administrate.rb` with the contents: ``` Administrate::Engine.add_javascript "my_plugin/script" Administrate::Engine.add_stylesheet "my_plugin/styles" ``` * [thoughtbot#567] [FEATURE] Add a partial for rendering HTML links to stylesheets. This is useful for plugin developers, as well as people who want to add custom stylesheets on a page-by-page basis using `content_for(:stylesheet)`. * [thoughtbot#492] [FEATURE] Translate attribute labels on show and index pages. To customize an attribute label, add translations according to the structure: ``` en: helpers: label: customer: name: Full Name ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
There was uncertainty about how to create custom labels for fields. In #451, it was suggested that we could use I18n translations to solve the problem.
If we accept that as the standard way to set custom labels, we should have a test for it.
Solution:
To Do: