Default all labels to human_attribute_name instead of raw attr_name #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing on appraisal: Don’t think that’s my changes…? |
|
I agree with this pull request. |
|
Hi @pcantrell! Thanks for your PR! I think I prefer how this standardises things. It's been a while, but would you be able to rebase on the current Are we also able to test this change? |
|
Closing in favour of #1064, which I hope we'll merge soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Administrate is inconsistent about the default human-visible attribute name. It uses Rails’s attr name localization for form labels, but defaults to showing the raw Ruby attribute name in other views.
This PR brings the collection & show views into line with what the form shows.
There is also a collection/show discrepancy in how
titleizegets applied — to the localized version in collection, only the default in show — but I’ve left that in place for now.