Accepts association with :inverse_of set to false and non standard foreign key #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssociation turned off
houndci-bot
reviewed
Jun 5, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Lint/EndAlignment has the wrong namespace - should be Layout
.rubocop.yml: Lint/EndAlignment has the wrong namespace - should be Layout .rubocop.yml: Lint/DefEndAlignment has the wrong namespace - should be Layout .rubocop.yml: Lint/BlockAlignment has the wrong namespace - should be Layout .rubocop.yml: Lint/ConditionPosition has the wrong namespace - should be Layout Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it)
|
Hello, is there anything missing for this PR to be merged? |
|
@inkstak Sorry! I've been very busy lately. This looks good though, so I'll merge it now. |
Merged
guialbuk
added a commit
that referenced
this pull request
Jan 9, 2020
### Features * Add support for `optional: false` in `belongs_to` associations. ([#1237]) * Add support for associations with `inverse_of: false` and non-standard foreign key ([#1106]) ### Bug fixes * Fix typos in documentation of `allow_values` ([#1241]) * Fix appraisal command in CONTRIBUTING.md file ([#1253]) ### Improvements * Remove minitest reporters dependency ([#1251]) * Development dependency updates [#1106]: #1106 [#1237]: #1237 [#1241]: #1241 [#1253]: #1253
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shoulda-matchers failed to validate such association: