Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version 4.2.0 #1268

Merged
merged 7 commits into from
Jan 9, 2020
Merged

Release version 4.2.0 #1268

merged 7 commits into from
Jan 9, 2020

Conversation

guialbuk
Copy link
Collaborator

@guialbuk guialbuk commented Dec 26, 2019

Features

  • Add support for optional: false in belongs_to associations. (#1237)
  • Add support for associations with inverse_of: false and non-standard foreign key (#1106)

Bug fixes

  • Fix typos in documentation of allow_values (#1241)
  • Fix appraisal command in CONTRIBUTING.md file (#1253)

Improvements

Copy link
Collaborator

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Make sure to re-run appraisal install locally as the version shows up in all of the generated gemfiles as well. Other than that, feel free to release!

@@ -0,0 +1 @@
ruby 2.6.5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh what is this??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for asdf and other tools that manage versions for different languages

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mange Is to manage other languages

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed .tool-version as it's kind of redundant. Multiple language manages can fallback to .ruby-version.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! No worries. I was just wondering! Regardless asdf seems like a pretty cool tool — I don't know how I've never heard of it before 🤯

@guialbuk
Copy link
Collaborator Author

guialbuk commented Jan 7, 2020

This looks good. Make sure to re-run appraisal install locally as the version shows up in all of the generated gemfiles as well. Other than that, feel free to release!

Hi @mcmire . I was running appraisal install but there are no shoulda-matcher versions in the generated Gemfiles, as unit tests directly require the gem code.

For acceptance tests, the gem is directly loaded from the filesystem:

gem_options = { path: fs.root_directory }

So I think we don't need to update any generated gemfiles. Or maybe I'm missing something?

@mcmire
Copy link
Collaborator

mcmire commented Jan 8, 2020

@guialbuk Yup you're totally right! Sometimes whenever you use Appraisal you see that sort of thing, but it looks in order for shoulda-matchers lines to appear in the individual gemfiles, we would have to have a gemspec line in the main Gemfile, which we do not. So, you're good!

@O330oei
Copy link

O330oei commented Jan 8, 2020

This looks good. Make sure to re-run appraisal install locally as the version shows up in all of the generated gemfiles as well. Other than that, feel free to release!

Hi @mcmire . I was running appraisal install but there are no shoulda-matcher versions in the generated Gemfiles, as unit tests directly require the gem code.

For acceptance tests, the gem is directly loaded from the filesystem:

gem_options = { path: fs.root_directory }

So I think we don't need to update any generated gemfiles. Or maybe I'm missing something?

convert

@guialbuk guialbuk merged commit 068b0e7 into master Jan 9, 2020
@guialbuk guialbuk deleted the release-v4.2.0 branch January 9, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants