-
-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release version 4.2.0 #1268
Release version 4.2.0 #1268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Make sure to re-run appraisal install
locally as the version shows up in all of the generated gemfiles as well. Other than that, feel free to release!
d16a2f2
to
bf72c6e
Compare
@@ -0,0 +1 @@ | |||
ruby 2.6.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh what is this??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for asdf
and other tools that manage versions for different languages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mange Is to manage other languages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed .tool-version
as it's kind of redundant. Multiple language manages can fallback to .ruby-version
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! No worries. I was just wondering! Regardless asdf
seems like a pretty cool tool — I don't know how I've never heard of it before 🤯
Hi @mcmire . I was running For acceptance tests, the gem is directly loaded from the filesystem:
So I think we don't need to update any generated gemfiles. Or maybe I'm missing something? |
@guialbuk Yup you're totally right! Sometimes whenever you use Appraisal you see that sort of thing, but it looks in order for |
convert |
Features
optional: false
inbelongs_to
associations. (#1237)inverse_of: false
and non-standard foreign key (#1106)Bug fixes
allow_values
(#1241)Improvements