Drop git ls-files in gemspec
#1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: thoughtbot#1353 Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
utkarsh2102
force-pushed
the
drop-git-in-gemspec
branch
from
e5a0c22 to
13d874f
Compare
More about the extension can be found at: https://docs.rubocop.org/rubocop-packaging/ Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
Avoid using `require_relative` with relative path to lib. Use `require` instead. More details about this cop can be found at: https://docs.rubocop.org/rubocop-packaging/cops_packaging.html#packagingrequirerelativehardcodinglib Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
utkarsh2102
force-pushed
the
drop-git-in-gemspec
branch
from
13d874f to
0519f87
Compare
|
@mcmire, should be ready for your review now, could you please take a look? 😄 |
|
Thank you for these changes! Merged! |
Merged
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again 👋🏻
As discussed in #1353, this PR drops
gitin gemspec, thereby also helping in smooth downstream maintenance (in Debian, Fedora, and so on).Also adds the
Packagingextension of RuboCop. More about it can be found on https://docs.rubocop.org/rubocop-packaging.Closes: #1353
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>