Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop git ls-files in gemspec #1354

Merged
merged 3 commits into from
Sep 13, 2020
Merged

Drop git ls-files in gemspec #1354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1086fa
Drop `git ls-files` in gemspec
utkarsh2102 Sep 11, 2020
d95f5f7
Add the Packaging extension of RuboCop
utkarsh2102 Sep 11, 2020
0519f87
Use require over require_relative for cross-lib calls
utkarsh2102 Sep 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
require: rubocop-rails
require:
- rubocop-packaging
- rubocop-rails
AllCops:
NewCops: disable
TargetRubyVersion: 2.4
Expand Down
1 change: 1 addition & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ gem 'pry-byebug'
gem 'rake', '13.0.1'
gem 'rspec', '~> 3.9'
gem 'rubocop', require: false
gem 'rubocop-packaging', require: false
utkarsh2102 marked this conversation as resolved.
Show resolved Hide resolved
gem 'rubocop-rails', require: false
gem 'warnings_logger'
gem 'zeus', require: false
Expand Down
3 changes: 3 additions & 0 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ GEM
unicode-display_width (>= 1.4.0, < 2.0)
rubocop-ast (0.3.0)
parser (>= 2.7.1.4)
rubocop-packaging (0.4.0)
rubocop (~> 0.89)
rubocop-rails (2.0.1)
rack (>= 1.1)
rubocop (>= 0.70.0)
Expand All @@ -76,6 +78,7 @@ DEPENDENCIES
rouge
rspec (~> 3.9)
rubocop
rubocop-packaging
rubocop-rails
warnings_logger
yard
Expand Down
5 changes: 1 addition & 4 deletions shoulda-matchers.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,7 @@ Gem::Specification.new do |s|
'source_code_uri' => 'https://github.com/thoughtbot/shoulda-matchers',
}

s.files = Dir.chdir(File.expand_path(__dir__)) do
`git ls-files -z -- {docs,lib,README.md,MIT-LICENSE,shoulda-matchers.gemspec}`.
split("\x0")
end
s.files = Dir['{docs,lib}/**/*', 'README.md', 'MIT-LICENSE', 'shoulda-matchers.gemspec']
s.require_paths = ['lib']

s.required_ruby_version = '>= 2.4.0'
Expand Down
2 changes: 1 addition & 1 deletion tasks/documentation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
require_relative '../lib/shoulda/matchers/version'
require 'shoulda/matchers/version'
utkarsh2102 marked this conversation as resolved.
Show resolved Hide resolved
require 'erb'

module Shoulda
Expand Down