`TypeError` raised on new projects #46

stevepolitodesign · 2023-12-08T13:52:00Z

Node Version: v21.4.0
Yarn Version: v1.22.17
NPM Version: 10.2.4

Steps to reproduce:

Run mkdir stylelint && cd stylelint.
Run yarn init and follow prompts.
Run npm init stylelint
Run touch index.css

Run npx stylelint "**/*.css". Note the output:

 index.css
 1:1  ✖  Unexpected empty source  no-empty-source

1 problem (1 error, 0 warnings)

Run yarn add @thoughtbot/stylelint-config --dev

Update .stylelintrc.json.

{ "extends": ["@thoughtbot/stylelint-config"] }

Run npx stylelint "**/*.css". Note the output:

❯ npx stylelint "**/*.css"
TypeError: Cannot read properties of undefined (reading 'rejected')
    at Object.<anonymous> (/Users/polito/Sites/playground/stylelint/node_modules/stylelint-scss/src/rules/comment-no-    empty/index.js:12:42)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
    at Module.load (node:internal/modules/cjs/loader:1207:32)
    at Module._load (node:internal/modules/cjs/loader:1023:12)
    at Module.require (node:internal/modules/cjs/loader:1235:19)
    at require (node:internal/modules/helpers:176:18)
    at Object.<anonymous> (/Users/polito/Sites/playground/stylelint/node_modules/stylelint-scss/src/rules/index.js:31:23)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)

The text was updated successfully, but these errors were encountered:

In an effort to account for this [issue][], we pin `stylelint` and `@thoughtbot/stylelint-config` to specific versions. Unfortunately, we still see deprecation warnings. [issue]: thoughtbot/stylelint-config#46

Closes #1107 Closes #1143 Creates a holistic linting solution that covers JavaScript, CSS, Ruby and ERB. Introduces [scripts][] that leverage [@thoughtbot/eslint-config][], [@thoughtbot/stylelint-config][] and [prettier][]. Also introduces `.prettierrc` based off of our [Guides][]. We need to pin `stylelint` and `@thoughtbot/stlyelint-config` to specific versions to account for this [open issue][]. Unfortunately, running `yarn run lint:stylelint` results in deprecation warnings, which will need to be addressed separately. [scripts]: https://docs.npmjs.com/cli/v6/using-npm/scripts [@thoughtbot/eslint-config]: https://github.com/thoughtbot/eslint-config [@thoughtbot/stylelint-config]: https://github.com/thoughtbot/stylelint-config [prettier]: https://prettier.io [Guides]: https://github.com/thoughtbot/guides/blob/main/javascript/README.md#formatting [open issue]: thoughtbot/stylelint-config#46 Introduces `rake standard` which also runs `erblint` to lint ERB files via [better_html][], [erb_lint][] and [erblint-github][]. [better_html]: https://github.com/Shopify/better-html [erb_lint]: https://github.com/Shopify/erb-lint [erblint-github]: https://github.com/github/erblint-github A future commit will ensure these linting rules are run during CI. In an effort to support that future commit, we ensure to run `yarn run fix:prettier` and `bundle exec standard:fix_unsafely` once the generator is complete. Otherwise, CI would fail because of linting violations. We call `standard:fix_unsafely` since `standard:fix` returns an error status code on new Rails applications. Running `standard:fix_unsafely` fixes this issue and returns a success status code. It should be noted that we deliberately permit this generator to be invoked on API only applications, because those applications can still contain views, like ones used for mailers. Also improves the developer experience by introducing `with_test_suite` helper, allowing the caller to run the generator in an application using minitest or RSpec.

Closes #1107 Closes #1143 Creates a holistic linting solution that covers JavaScript, CSS, Ruby and ERB. Introduces [scripts][] that leverage [@thoughtbot/eslint-config][], [@thoughtbot/stylelint-config][] and [prettier][]. Also introduces `.prettierrc` based off of our [Guides][]. We need to pin `stylelint` and `@thoughtbot/stlyelint-config` to specific versions to account for this [open issue][]. Unfortunately, running `yarn run lint:stylelint` results in deprecation warnings, which will need to be addressed separately. [scripts]: https://docs.npmjs.com/cli/v6/using-npm/scripts [@thoughtbot/eslint-config]: https://github.com/thoughtbot/eslint-config [@thoughtbot/stylelint-config]: https://github.com/thoughtbot/stylelint-config [prettier]: https://prettier.io [Guides]: https://github.com/thoughtbot/guides/blob/main/javascript/README.md#formatting [open issue]: thoughtbot/stylelint-config#46 Introduces `rake standard` which also runs `erblint` to lint ERB files via [better_html][], [erb_lint][] and [erblint-github][]. [better_html]: https://github.com/Shopify/better-html [erb_lint]: https://github.com/Shopify/erb-lint [erblint-github]: https://github.com/github/erblint-github A future commit will ensure these linting rules are run during CI. In an effort to support that future commit, we ensure to run `yarn run fix:prettier` and `bundle exec standard:fix_unsafely` once the generator is complete. Otherwise, CI would fail because of linting violations. We call `standard:fix_unsafely` since `standard:fix` returns an error status code on new Rails applications. Running `standard:fix_unsafely` fixes this issue and returns a success status code. It should be noted that we deliberately permit this generator to be invoked on API only applications, because those applications can still contain views, like ones used for mailers. However, a future commit could explore removing the JavaScript linters. Also improves the developer experience by introducing `with_test_suite` helper, allowing the caller to run the generator in an application using minitest or RSpec.

nickcharlton · 2024-02-02T16:21:09Z

@stevepolitodesign, could you give v4.0.0 a go when you get a chance? I've updated a lot this project over the last few days which should mean it's working again well.

stevepolitodesign · 2024-02-02T17:47:20Z

@nickcharlton just tested again, and everything works as expected!

After the `v4.0.0` release of [@thoughtbot/stylelint-config][], the errors mentioned in [this issue][] no longer appear. This alleviates us from having to pin these dependencies. [@thoughtbot/stylelint-config]: https://github.com/thoughtbot/stylelint-config/releases/tag/v4.0.0 [this issue]: thoughtbot/stylelint-config#46

Closes #1107 Closes #1143 Creates a holistic linting solution that covers JavaScript, CSS, Ruby and ERB. Introduces [scripts][] that leverage [@thoughtbot/eslint-config][], [@thoughtbot/stylelint-config][] and [prettier][]. Also introduces `.prettierrc` based off of our [Guides][]. We need to pin `stylelint` and `@thoughtbot/stlyelint-config` to specific versions to account for this [open issue][]. Unfortunately, running `yarn run lint:stylelint` results in deprecation warnings, which will need to be addressed separately. [scripts]: https://docs.npmjs.com/cli/v6/using-npm/scripts [@thoughtbot/eslint-config]: https://github.com/thoughtbot/eslint-config [@thoughtbot/stylelint-config]: https://github.com/thoughtbot/stylelint-config [prettier]: https://prettier.io [Guides]: https://github.com/thoughtbot/guides/blob/main/javascript/README.md#formatting [open issue]: thoughtbot/stylelint-config#46 Introduces `rake standard` which also runs `erblint` to lint ERB files via [better_html][], [erb_lint][] and [erblint-github][]. [better_html]: https://github.com/Shopify/better-html [erb_lint]: https://github.com/Shopify/erb-lint [erblint-github]: https://github.com/github/erblint-github A future commit will ensure these linting rules are run during CI. In an effort to support that future commit, we ensure to run `yarn run fix:prettier` and `bundle exec standard:fix_unsafely` once the generator is complete. Otherwise, CI would fail because of linting violations. We call `standard:fix_unsafely` since `standard:fix` returns an error status code on new Rails applications. Running `standard:fix_unsafely` fixes this issue and returns a success status code. It should be noted that we deliberately permit this generator to be invoked on API only applications, because those applications can still contain views, like ones used for mailers. However, a future commit could explore removing the JavaScript linters. Also improves the developer experience by introducing `with_test_suite` helper, allowing the caller to run the generator in an application using minitest or RSpec.

After the `v4.0.0` release of [@thoughtbot/stylelint-config][], the errors mentioned in [this issue][] no longer appear. This alleviates us from having to pin these dependencies. [@thoughtbot/stylelint-config]: https://github.com/thoughtbot/stylelint-config/releases/tag/v4.0.0 [this issue]: thoughtbot/stylelint-config#46

stevepolitodesign mentioned this issue Dec 11, 2023

Introduce suspenders:lint generator thoughtbot/suspenders#1148

Merged

2 tasks

stevepolitodesign mentioned this issue Feb 2, 2024

Suspenders 3.0.0 thoughtbot/suspenders#1135

Merged

17 tasks

stevepolitodesign closed this as completed Feb 2, 2024

stevepolitodesign mentioned this issue Mar 1, 2024

Update front-end linting dependencies thoughtbot/suspenders#1163

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`TypeError` raised on new projects #46

`TypeError` raised on new projects #46

stevepolitodesign commented Dec 8, 2023 •

edited

Loading

nickcharlton commented Feb 2, 2024

stevepolitodesign commented Feb 2, 2024

TypeError raised on new projects #46

TypeError raised on new projects #46

Comments

stevepolitodesign commented Dec 8, 2023 • edited Loading

nickcharlton commented Feb 2, 2024

stevepolitodesign commented Feb 2, 2024

`TypeError` raised on new projects #46

`TypeError` raised on new projects #46

stevepolitodesign commented Dec 8, 2023 •

edited

Loading