Skip to content

Commit

Permalink
Update front-end linting dependencies (#1163)
Browse files Browse the repository at this point in the history
After the `v4.0.0` release of [@thoughtbot/stylelint-config][], the
errors mentioned in [this issue][] no longer appear.

This alleviates us from having to pin these dependencies.

[@thoughtbot/stylelint-config]: https://github.com/thoughtbot/stylelint-config/releases/tag/v4.0.0
[this issue]: thoughtbot/stylelint-config#46
  • Loading branch information
stevepolitodesign authored Mar 1, 2024
1 parent fc8793d commit 9f624b1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/generators/suspenders/lint_generator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ class LintGenerator < Rails::Generators::Base
desc "Creates a holistic linting solution that covers JavaScript, CSS, Ruby and ERB."

def install_dependencies
run "yarn add stylelint@^15.10.1 eslint @thoughtbot/stylelint-config@3.0.0 @thoughtbot/eslint-config npm-run-all prettier --dev"
run "yarn add stylelint eslint @thoughtbot/stylelint-config @thoughtbot/eslint-config npm-run-all prettier --dev"
end

def install_gems
Expand Down
2 changes: 1 addition & 1 deletion test/generators/suspenders/lint_generator_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class LintGeneratorTest < Rails::Generators::TestCase
capture(:stderr) do
output = run_generator

assert_match(/yarn add stylelint@\^15\.10\.1 eslint @thoughtbot\/stylelint-config@3\.0\.0 @thoughtbot\/eslint-config npm-run-all prettier --dev/, output)
assert_match(/yarn add stylelint eslint @thoughtbot\/stylelint-config @thoughtbot\/eslint-config npm-run-all prettier --dev/, output)
end
end

Expand Down

0 comments on commit 9f624b1

Please sign in to comment.